From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guennadi Liakhovetski Subject: Re: [PATCH/RFC 2/3] ethernet: add a PHY reset GPIO DT binding to sh_eth Date: Mon, 8 Jul 2013 12:49:47 +0200 (CEST) Message-ID: References: <1359043653-11374-1-git-send-email-g.liakhovetski@gmx.de> <1359043653-11374-3-git-send-email-g.liakhovetski@gmx.de> <7921225.sfO3PIeLVS@avalon> <20130125182137.GB7393@obsidianresearch.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: linux-sh-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, Magnus Damm , Simon Horman , Laurent Pinchart , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Jason Gunthorpe Return-path: In-Reply-To: <20130125182137.GB7393-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" List-Id: netdev.vger.kernel.org Hi Jason Sorry for resuming an old thread, but I'd like to get this solved eventually. On Fri, 25 Jan 2013, Jason Gunthorpe wrote: > On Fri, Jan 25, 2013 at 11:34:55AM +0100, Guennadi Liakhovetski wrote: > > > > Is there no need to reset the phy at runtime ? > > > > No idea, I'm not developing the driver, I'm just porting one specific > > feature from one API to another with no functional changes (apart from > > postponing setting the GPIO). > > Generally Linux relies on resetting the phy via the inband MDIO method, > which is what Linux does. It is pretty much never required to reset > via the hard pin - but you do need to generate a robust reset edge on > the reset pin once after power up. This all sounds good. So, is there a preferred way to do that? Where in the ethernet framework would you propose to hook up such a reset edge generation? Thanks Guennadi --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/