From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guennadi Liakhovetski Subject: Re: [PATCH] net: sh_eth: Fix RX packets errors on R8A7740 Date: Wed, 16 Oct 2013 07:37:20 +0200 (CEST) Message-ID: References: <1381127365-6521-1-git-send-email-nh-ky@jinso.co.jp> <1381127365-6521-2-git-send-email-nh-ky@jinso.co.jp> <52597FC0.4090801@cogentembedded.com> <525DB81C.6010106@cogentembedded.com> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Cc: Nguyen Hong Ky , "David S. Miller" , netdev@vger.kernel.org, Ryusuke Sakato , Simon Horman To: Sergei Shtylyov Return-path: Received: from moutng.kundenserver.de ([212.227.17.9]:53947 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751385Ab3JPFhc (ORCPT ); Wed, 16 Oct 2013 01:37:32 -0400 In-Reply-To: <525DB81C.6010106@cogentembedded.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 16 Oct 2013, Sergei Shtylyov wrote: > Hello. > > On 10/15/2013 11:28 AM, Guennadi Liakhovetski wrote: > > > > > This patch will fix RX packets errors when receiving big size > > > > of data by set bit RNC = 1. > > > > > RNC - Receive Enable Control > > > > > 0: Upon completion of reception of one frame, the E-DMAC writes > > > > the receive status to the descriptor and clears the RR bit in > > > > EDRRR to 0. > > > > > 1: Upon completion of reception of one frame, the E-DMAC writes > > > > (writes back) the receive status to the descriptor. In addition, > > > > the E-DMAC reads the next descriptor and prepares for reception > > > > of the next frame. > > > > > In addition, for get more stable when receiving packets, I set > > > > maximum size for the transmit/receive FIFO and inserts padding > > > > in receive data. > > > > > Signed-off-by: Nguyen Hong Ky > > > > --- > > > > drivers/net/ethernet/renesas/sh_eth.c | 4 ++++ > > > > 1 files changed, 4 insertions(+), 0 deletions(-) > > > > > diff --git a/drivers/net/ethernet/renesas/sh_eth.c > > > > b/drivers/net/ethernet/renesas/sh_eth.c > > > > index a753928..11d34f0 100644 > > > > --- a/drivers/net/ethernet/renesas/sh_eth.c > > > > +++ b/drivers/net/ethernet/renesas/sh_eth.c > > > > @@ -649,12 +649,16 @@ static struct sh_eth_cpu_data r8a7740_data = { > > > > .eesr_err_check = EESR_TWB1 | EESR_TWB | EESR_TABT | EESR_RABT > > > > | > > > > EESR_RFE | EESR_RDE | EESR_RFRMER | EESR_TFE > > > > | > > > > EESR_TDE | EESR_ECI, > > > > + .fdr_value = 0x0000070f, > > > > + .rmcr_value = 0x00000001, > > > > > > > > .apr = 1, > > > > .mpr = 1, > > > > .tpauser = 1, > > > > .bculr = 1, > > > > .hw_swap = 1, > > > > + .rpadir = 1, > > > > + .rpadir_value = 2 << 16, > > > > .no_trimd = 1, > > > > .no_ade = 1, > > > > .tsu = 1, > > > > Guennadi, could you check if this patch fixes your issue with NFS. > > > Make > > > sure it applies to 'r8a7740_data' (it was misapplied to DaveM's tree). > > > Yes, the current -next, which includes this patch (in a slightly different > > form) boots fine over NFS for me. > > I don't know what you mean by "slightly different form" exactly. Also, I > was unable to locate the fresh -next tree. git://gitorious.org/thierryreding/linux-next.git > 'net-next.git' contains this patch > in a mismerged form, 'net.git' has Simon's patch that corrects this mismerge. > > > Thanks > > Guennadi > > WBR, Sergei > --- Guennadi Liakhovetski, Ph.D. Freelance Open-Source Software Developer http://www.open-technology.de/