From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Toptygin Subject: Re: [PATCH] fix unlikely usage in tcp_transmit_skb() Date: Fri, 28 Apr 2006 23:45:01 +0000 (UTC) Message-ID: References: <20060428.152551.50641016.davem@davemloft.net> Mime-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: hzhong@gmail.com, netdev@vger.kernel.org Return-path: Received: from mx.freeshell.ORG ([192.94.73.18]:31711 "EHLO sdf.lonestar.org") by vger.kernel.org with ESMTP id S965004AbWD1Xpn (ORCPT ); Fri, 28 Apr 2006 19:45:43 -0400 To: "David S. Miller" In-Reply-To: <20060428.152551.50641016.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On Fri, 28 Apr 2006, David S. Miller wrote: > From: Hua Zhong > Date: Wed, 26 Apr 2006 09:50:28 -0700 (PDT) > >> [I hope this time it's OK - I'm sending from pine/Linux] > > It adds an extra space in the diff lines which corrupts > the patch. You can work around this by enabling quell-flowed-text - then pine will never mangle patches. Currently (pine4.64), if you're disabling flowed text on a per-message basis with ^V before sending, patches containing trailing whitespace will get mangled. Pine labels the message as not flowed, but does the mangling anyway :-/ Tooting my own horn here, but I submitted a pine patch this week which fixes the issue. Hopefully, the next pine release will behave correctly. You'll still have to remember to hit ^V before sending mail containing patches, and you should always use ^R to include patch files, since newlines in the input are treated magically. Or, you can enable quell-flowed-text, and pretend the whole flowed text feature never happened. I'll shut up about pine now :-) Alexey