netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Meelis Roos <mroos@linux.ee>
To: netdev@vger.kernel.org, Sridhar Samudrala <sri@us.ibm.com>,
	lksctp-developers@lists.sourceforge.net
Subject: [PATCH] warning in SCTP
Date: Thu, 2 Nov 2006 09:29:16 +0200 (EET)	[thread overview]
Message-ID: <Pine.SOC.4.61.0611020925530.1919@math.ut.ee> (raw)


   CC [M]  net/sctp/sm_make_chunk.o
net/sctp/sm_make_chunk.c: In function 'sctp_unpack_cookie':
net/sctp/sm_make_chunk.c:1358: warning: initialization discards qualifiers from pointer target type

The reason is that sctp_unpack_cookie() takes a const struct 
sctp_endpoint and modifies the digest in it (digest being embedded in 
the struct, not a pointer). So sctp_unpack_cookie really does not use 
the argument as const, mark it as such.

Signed-off-by: Meelis Roos <mroos@linux.ee>

diff --git a/include/net/sctp/sm.h b/include/net/sctp/sm.h
index de313de..ef80489 100644
--- a/include/net/sctp/sm.h
+++ b/include/net/sctp/sm.h
@@ -272,7 +272,7 @@ void sctp_generate_heartbeat_event(unsig

  void sctp_ootb_pkt_free(struct sctp_packet *);

-struct sctp_association *sctp_unpack_cookie(const struct sctp_endpoint *,
+struct sctp_association *sctp_unpack_cookie(struct sctp_endpoint *,
  				       const struct sctp_association *,
  				       struct sctp_chunk *,
  				       gfp_t gfp, int *err,
diff --git a/net/sctp/sm_make_chunk.c b/net/sctp/sm_make_chunk.c
index 507dff7..3d41a9c 100644
--- a/net/sctp/sm_make_chunk.c
+++ b/net/sctp/sm_make_chunk.c
@@ -1346,7 +1346,7 @@ nodata:

  /* Unpack the cookie from COOKIE ECHO chunk, recreating the association.  */
  struct sctp_association *sctp_unpack_cookie(
-	const struct sctp_endpoint *ep,
+	struct sctp_endpoint *ep,
  	const struct sctp_association *asoc,
  	struct sctp_chunk *chunk, gfp_t gfp,
  	int *error, struct sctp_chunk **errp)

-- 
Meelis Roos (mroos@linux.ee)

             reply	other threads:[~2006-11-02  7:29 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-02  7:29 Meelis Roos [this message]
2006-11-02  8:16 ` [PATCH] warning in SCTP David Miller
2006-11-02  8:22   ` Meelis Roos
2006-11-02  8:30     ` Oleg Verych
2006-11-02  8:39   ` David Miller
2006-11-02  8:49     ` Meelis Roos
2006-11-02  9:12       ` Meelis Roos
2006-11-02  9:22     ` Meelis Roos
2006-11-02 16:09       ` Vlad Yasevich
2006-11-02 18:29         ` Sridhar Samudrala
2006-11-10  0:30           ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.SOC.4.61.0611020925530.1919@math.ut.ee \
    --to=mroos@linux.ee \
    --cc=lksctp-developers@lists.sourceforge.net \
    --cc=netdev@vger.kernel.org \
    --cc=sri@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).