Re: [PATCH] warning in SCTP

[Meelis Roos <mroos@linux.ee>]

> Actually, I'm backing this one out, it creates new warnings because
> callers of this function pass in a "const" pointer.

OK, fair enough. Will have a look.

> Please test the complete build when doing warning fixes like
> this in the future, thanks.

Sure. Evenso, I did test full make after the single compile was fine 
(still have it in my scrollback so here it is). So did I do anything 
wrong here or do we have some dependencies broken somewhere or what?
Now that I read the transript again I can see that despite modifying 
include/net/sctp/sm.h nothing was really recompiled - should have 
noticed.

mroos@rhn:~/compile/linux-2.6$ vi net/sctp/sm_make_chunk.c
mroos@rhn:~/compile/linux-2.6$ !make
make net/sctp/sm_make_chunk.o
   CHK     include/linux/version.h
   CHK     include/linux/utsrelease.h
   CC      net/sctp/sm_make_chunk.o
net/sctp/sm_make_chunk.c:1353: error: conflicting types for 'sctp_unpack_cookie'
include/net/sctp/sm.h:279: error: previous declaration of 'sctp_unpack_cookie' was here
make[1]: *** [net/sctp/sm_make_chunk.o] Error 1
make: *** [net/sctp/sm_make_chunk.o] Error 2
mroos@rhn:~/compile/linux-2.6$ vi include/net/sctp/sm.h
mroos@rhn:~/compile/linux-2.6$ make net/sctp/sm_make_chunk.o
   CHK     include/linux/version.h
   CHK     include/linux/utsrelease.h
   CC      net/sctp/sm_make_chunk.o
mroos@rhn:~/compile/linux-2.6$ make
   CHK     include/linux/version.h
   CHK     include/linux/utsrelease.h
   CHK     include/linux/compile.h
   MODPOST vmlinux
Kernel: arch/i386/boot/bzImage is ready  (#274)
   Building modules, stage 2.
   MODPOST 511 modules
mroos@rhn:~/compile/linux-2.6$ cg-diff  > ~/sctppatch


-- 
Meelis Roos (mroos@linux.ee)