* via-velocity warnings on sparc64
@ 2008-09-25 8:15 Meelis Roos
2008-09-25 21:37 ` Francois Romieu
0 siblings, 1 reply; 3+ messages in thread
From: Meelis Roos @ 2008-09-25 8:15 UTC (permalink / raw)
To: romieu; +Cc: netdev
Noticed this while compiling 2.6.27-rc7+git on sparc64 - maybe it is of
interest.
CC [M] drivers/net/via-velocity.o
drivers/net/via-velocity.c: In function 'velocity_free_rd_ring':
drivers/net/via-velocity.c:1275: warning: cast from pointer to integer of different size
drivers/net/via-velocity.c: In function 'velocity_free_td_ring_entry':
drivers/net/via-velocity.c:1336: warning: cast from pointer to integer of different size
--
Meelis Roos (mroos@linux.ee)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: via-velocity warnings on sparc64
2008-09-25 8:15 via-velocity warnings on sparc64 Meelis Roos
@ 2008-09-25 21:37 ` Francois Romieu
2008-09-26 6:22 ` Meelis Roos
0 siblings, 1 reply; 3+ messages in thread
From: Francois Romieu @ 2008-09-25 21:37 UTC (permalink / raw)
To: Meelis Roos; +Cc: netdev
Meelis Roos <mroos@linux.ee> :
> Noticed this while compiling 2.6.27-rc7+git on sparc64 - maybe it is of
> interest.
>
> CC [M] drivers/net/via-velocity.o
> drivers/net/via-velocity.c: In function 'velocity_free_rd_ring':
> drivers/net/via-velocity.c:1275: warning: cast from pointer to integer of different size
> drivers/net/via-velocity.c: In function 'velocity_free_td_ring_entry':
> drivers/net/via-velocity.c:1336: warning: cast from pointer to integer of different size
Something like the patch below maybe ?
diff --git a/drivers/net/via-velocity.c b/drivers/net/via-velocity.c
index 007c129..ad20f96 100644
--- a/drivers/net/via-velocity.c
+++ b/drivers/net/via-velocity.c
@@ -1272,7 +1272,7 @@ static void velocity_free_rd_ring(struct velocity_info *vptr)
continue;
pci_unmap_single(vptr->pdev, rd_info->skb_dma, vptr->rx.buf_sz,
PCI_DMA_FROMDEVICE);
- rd_info->skb_dma = (dma_addr_t) NULL;
+ rd_info->skb_dma = 0;
dev_kfree_skb(rd_info->skb);
rd_info->skb = NULL;
@@ -1333,7 +1333,7 @@ static void velocity_free_td_ring_entry(struct velocity_info *vptr,
if (td_info->skb_dma[i]) {
pci_unmap_single(vptr->pdev, td_info->skb_dma[i],
td_info->skb->len, PCI_DMA_TODEVICE);
- td_info->skb_dma[i] = (dma_addr_t) NULL;
+ td_info->skb_dma[i] = 0;
}
}
dev_kfree_skb(td_info->skb);
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-09-26 6:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-09-25 8:15 via-velocity warnings on sparc64 Meelis Roos
2008-09-25 21:37 ` Francois Romieu
2008-09-26 6:22 ` Meelis Roos
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).