From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 39774468C38 for ; Tue, 1 Sep 2026 21:39:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788298798; cv=none; b=WjWflUIPzEZ+1OpHD0d3cDYjlXD8ko+CRN34jwona741He4tLfZberUOMhCnXAGL5j6UXEAlOyXeQ4n6S3Ku51y+7pOhosDrWDPLzc4npoYPJRQR2Jf79yBH/asaFnU4TXdqOG7Jh8DqCEsnCbtGV7XeJdCM6FALpqKp4LgPTlQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788298798; c=relaxed/simple; bh=sziN1WTxdrWA0/eaCfdoIvXyznvXx429BIdmYLBm8WQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=qpHnwGOR1TgsOln2gYJGW7mnj7RdcHKUnLm4DoiBYqvQwfcPbfhZ613jxL5Bp97kCXcNiDBgA9afEQzZNRBAzUlgJA9GDFIMqvrOVAZAeMVnb3V/WLr9yQDWH+AsBBHmBdp8OzKkVOxVX7EzU9SjAWTqOF1QaMavpoat0nxiPsE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mojatatu.com; spf=none smtp.mailfrom=mojatatu.com; dkim=pass (1024-bit key) header.d=mojatatu.com header.i=@mojatatu.com header.b=b4itef3C; arc=none smtp.client-ip=209.85.219.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mojatatu.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=mojatatu.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=mojatatu.com header.i=@mojatatu.com header.b="b4itef3C" Received: by mail-qv1-f46.google.com with SMTP id 6a1803df08f44-90cc107c451so2502306d6.0 for ; Tue, 01 Sep 2026 14:39:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu.com; s=google; t=1788298796; x=1788903596; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=W5MvV0x1EBsSpklgDw3P0bUHlzoYD1WHBSUfOtcrQ6g=; b=b4itef3C81xNUAoW00Iqevzmauh9QMmk2YjuMeajbxeB08/X0OcjIeKX1s0j4adCLA vPVZHZFpXvkiE43t9dgP1tsVwsZvoUdp17Ap4bRuFjyizOSF/dipTaFm9TjWx14q1JQF Ca3fF/0WY37FT87ebKEdQtScVDwl3tFS2xaOE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788298796; x=1788903596; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=W5MvV0x1EBsSpklgDw3P0bUHlzoYD1WHBSUfOtcrQ6g=; b=JuAa0KlckM9gbqZUGGcmJBER4owrC9/IpAVrxxfZN3eyjCoF/wwGMo4RfMtPYrfsgH 3kp1ppuz/N4R0WXtQHd65MHFx40/G62wnkL0rWm9tcOxyFW40hB9XpuG4U1OFByjgzwX Xby/EJAgeRldRoOOhzIAh8tM0oHzufuZKVFpSqIJwn77PLSyy4+hK/pY6OORyIUCfOTF AfAww4Xj6F9S0bcq00HPJrDPbN8BWBT/ujiLWLb5fMsbmtbSC0NwFqNSEOGiFELiSwcs mBe4JiFMXHMr5HNN/ni4NL2DRDMGw4yEk1dsYBBStflxUPPQQQ84xMdKecK7ObMhcCLd Kk1w== X-Gm-Message-State: AFuF++lagQbkV/NuM4RJFti+LcbnMk0Aaj+ZI0nBJo3fKAzvs018Qf7C DjbA1nvFjORfwl2cbZ5xf2FPSQm7CVxGqsmJrVeozwxNRDnlmq4wo0ggt16rWk6kwMrHIus0rjm 9mvV9qA== X-Gm-Gg: AYBFou0mRX9RRDsNPIXiN63XrekfxopAvAOBhF7pMvmMYRpFiklqfdDXR0T1ZU7GYvF bM4L06QqMZ+eptWx3av3NyEnLgIHwNwDC0zA5ltrAIn+fVoT1GQ6FRdOLSm1wr4gg/bmJ9UmzrW pvrIyUjUqxDKASRkeuSI9+1+BxYginapWzZwVbE0S3u2S9islkda4tdzVs0gGJMWMwHsZjYopx/ 0w1M+puPfhZCw+CR8dBoSuxBkBL4Ud0P9n/JireA3x6jHNspwcIGmh7FEDk8z4026aVBOP6NhzI 2bGvV/GPb7SWpZ0zWsiQhai8P0dsD73kbVpAfy9NBparsnggXOvW11VgBfJNk7yx6MyHi8IV8Dd LMtsO/CHe2oIImVZy+Juvlo1BMDadPhIUFI4Oop4lPLfcBbml/sfH4AAGAJIQ9up+i+1eBWhEOc DYxW+L9Tp9kOq0fmsmTLVHk3ALV0Soh7hRR3tHFx144WZcJ8G/8pUfAx29PJnf0nmw1kYs8QyYo yI+3f2HnuZbQZZZHYugMRTkuEXXxqTz6inmdFxGk0gD+3tr X-Received: by 2002:a05:6214:f61:b0:90e:9665:71b9 with SMTP id 6a1803df08f44-90ebafb8dc6mr9465336d6.27.1788298795811; Tue, 01 Sep 2026 14:39:55 -0700 (PDT) Received: from majuu.waya ([184.144.29.222]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-90e9ee08710sm3458426d6.2.2026.09.01.14.39.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 01 Sep 2026 14:39:55 -0700 (PDT) From: Jamal Hadi Salim To: netdev@vger.kernel.org Cc: Jamal Hadi Salim , Jiri Pirko , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Victor Nogueira , Vega , stable@vger.kernel.org, =?UTF-8?q?Toke=20H=C3=B8iland-J=C3=B8rgensen?= , Vijay Subramanian , Petr Machata , Chia-Yu Chang Subject: [PATCH net v3 6/9] net/sched: pie: clamp psched_mtu in pie_drop_early Date: Tue, 1 Sep 2026 17:39:27 -0400 Message-Id: X-Mailer: git-send-email 2.34.1 In-Reply-To: References: Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit pie_drop_early() calls psched_mtu() with no clamp. With mtu=0x80000000 the bytemode divide silently zeroes the drop probability, disabling AQM. Clamp to [1, 1<<20]. Conditions to recreate the bug: CONFIG_NET_SCH_PIE=y. Requires CAP_NET_ADMIN (namespace-local via unshare -Urn suffices). tc qdisc add dev dummy0 root pie tc qdisc change dev dummy0 root pie stab data 32768 size_log 15 cell_log 0 Fixes: d4b36210c2e6 ("net: pkt_sched: PIE AQM scheme") Reported-by: Vega Reviewed-by: Toke Høiland-Jørgensen Tested-by: Victor Nogueira Signed-off-by: Jamal Hadi Salim --- net/sched/sch_pie.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sched/sch_pie.c b/net/sched/sch_pie.c index b41f2def2e2c..3b7863ffd284 100644 --- a/net/sched/sch_pie.c +++ b/net/sched/sch_pie.c @@ -35,7 +35,7 @@ bool pie_drop_early(struct Qdisc *sch, struct pie_params *params, { u64 rnd; u64 local_prob = vars->prob; - u32 mtu = psched_mtu(qdisc_dev(sch)); + u32 mtu = clamp_t(u32, psched_mtu(qdisc_dev(sch)), 1, 1 << 20); /* If there is still burst allowance left skip random early drop */ if (vars->burst_time > 0) -- 2.43.0