From: Bhaskar Chowdhury <unixbhaskar@gmail.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: mw@semihalf.com, linux@armlinux.org.uk, davem@davemloft.net,
kuba@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, rdunlap@infradead.org
Subject: Re: [PATCH V2] drivers: net: marvell: Fix two spellings, controling to controlling and oen to one
Date: Tue, 12 Jan 2021 14:46:47 +0530 [thread overview]
Message-ID: <X/1o/0kYmtvZAU4g@Gentoo> (raw)
In-Reply-To: <458cf124-1c35-3761-4558-53283213cad8@embeddedor.com>
[-- Attachment #1: Type: text/plain, Size: 1532 bytes --]
On 23:20 Mon 11 Jan 2021, Gustavo A. R. Silva wrote:
>
>
>On 1/11/21 23:13, Bhaskar Chowdhury wrote:
>> s/controling/controlling/
>>
>> s/oen/one/
>>
>> Signed-off-by: Bhaskar Chowdhury <unixbhaskar@gmail.com>
>> ---
>> As Gustavo mentioned in reply, so included that missed one before
>
>This is not how you version patches for maintainers and reviewers to
>know you made changes to the patch.
>
Ahhh... Recollects my faint memory about it ...let me try again with that
>I encourage you to take a look at this to see examples on how to properly
>version your patches and other good practices:
>
>https://kernelnewbies.org/Outreachyfirstpatch
>
>--
>Gustavo
>
>>
>> drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h
>> index 8867f25afab4..663157dc8062 100644
>> --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h
>> +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_cls.h
>> @@ -143,7 +143,7 @@ struct mvpp2_cls_c2_entry {
>> /* Number of per-port dedicated entries in the C2 TCAM */
>> #define MVPP22_CLS_C2_PORT_N_FLOWS MVPP2_N_RFS_ENTRIES_PER_FLOW
>>
>> -/* Each port has oen range per flow type + one entry controling the global RSS
>> +/* Each port has one range per flow type + one entry controlling the global RSS
>> * setting and the default rx queue
>> */
>> #define MVPP22_CLS_C2_PORT_RANGE (MVPP22_CLS_C2_PORT_N_FLOWS + 1)
>> --
>> 2.26.2
>>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2021-01-12 9:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 5:13 [PATCH V2] drivers: net: marvell: Fix two spellings, controling to controlling and oen to one Bhaskar Chowdhury
[not found] ` <458cf124-1c35-3761-4558-53283213cad8@embeddedor.com>
2021-01-12 9:16 ` Bhaskar Chowdhury [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/1o/0kYmtvZAU4g@Gentoo \
--to=unixbhaskar@gmail.com \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox