From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C987AC433E0 for ; Tue, 5 Jan 2021 20:07:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8577E22D5A for ; Tue, 5 Jan 2021 20:07:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727591AbhAEUHc (ORCPT ); Tue, 5 Jan 2021 15:07:32 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:50716 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725800AbhAEUHc (ORCPT ); Tue, 5 Jan 2021 15:07:32 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kwsbQ-00GEDG-2g; Tue, 05 Jan 2021 21:06:48 +0100 Date: Tue, 5 Jan 2021 21:06:48 +0100 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: netdev@vger.kernel.org, davem@davemloft.net, Jakub Kicinski , Lorenzo Bianconi , Thomas Petazzoni Subject: Re: [PATCH net-next] net: mvneta: fix error message when MTU too large for XDP Message-ID: References: <20210105163833.389-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210105163833.389-1-kabel@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Jan 05, 2021 at 05:38:33PM +0100, Marek Behún wrote: > The error message says that "Jumbo frames are not supported on XDP", but > the code checks for mtu > MVNETA_MAX_RX_BUF_SIZE, not mtu > 1500. > > Fix this error message. > > Signed-off-by: Marek Behún > Fixes: 0db51da7a8e9 ("net: mvneta: add basic XDP support") > Cc: Lorenzo Bianconi > Cc: Thomas Petazzoni > --- > drivers/net/ethernet/marvell/mvneta.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c > index 563ceac3060f..8adbfa25465d 100644 > --- a/drivers/net/ethernet/marvell/mvneta.c > +++ b/drivers/net/ethernet/marvell/mvneta.c > @@ -4432,7 +4432,7 @@ static int mvneta_xdp_setup(struct net_device *dev, struct bpf_prog *prog, > struct bpf_prog *old_prog; > > if (prog && dev->mtu > MVNETA_MAX_RX_BUF_SIZE) { > - NL_SET_ERR_MSG_MOD(extack, "Jumbo frames not supported on XDP"); > + NL_SET_ERR_MSG_MOD(extack, "XDP is not supported with MTU > %d", dev->mtu); > return -EOPNOTSUPP; Hi Marek In addition to the OMG, don't you actually want to print MVNETA_MAX_RX_BUF_SIZE, not the dev->mtu? Andrew