From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B379C433DB for ; Wed, 6 Jan 2021 22:39:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2870123142 for ; Wed, 6 Jan 2021 22:39:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727308AbhAFWj5 (ORCPT ); Wed, 6 Jan 2021 17:39:57 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:53942 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727034AbhAFWj5 (ORCPT ); Wed, 6 Jan 2021 17:39:57 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kxHSR-00GXFC-MK; Wed, 06 Jan 2021 23:39:11 +0100 Date: Wed, 6 Jan 2021 23:39:11 +0100 From: Andrew Lunn To: Heiner Kallweit Cc: Russell King - ARM Linux , Jakub Kicinski , David Miller , "netdev@vger.kernel.org" Subject: Re: [PATCH net-next] net: phy: replace mutex_is_locked with lockdep_assert_held in phylib Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Jan 06, 2021 at 02:03:40PM +0100, Heiner Kallweit wrote: > Switch to lockdep_assert_held(_once), similar to what is being done > in other subsystems. One advantage is that there's zero runtime > overhead if lockdep support isn't enabled. Hi Heiner I'm not sure we are bothered about performance here. MDIO operations are slow, a mutex check is fast relative to that. I wonder how many do development work with lockdep enabled? I think i prefer catching hard to find locking bugs earlier, verses a tiny performance overhead. Andrew