From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F668C433E0 for ; Sun, 10 Jan 2021 17:38:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D48CC2229C for ; Sun, 10 Jan 2021 17:38:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726655AbhAJRik (ORCPT ); Sun, 10 Jan 2021 12:38:40 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:60036 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726263AbhAJRik (ORCPT ); Sun, 10 Jan 2021 12:38:40 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kyef6-00HLWf-LF; Sun, 10 Jan 2021 18:37:56 +0100 Date: Sun, 10 Jan 2021 18:37:56 +0100 From: Andrew Lunn To: stefanc@marvell.com Cc: netdev@vger.kernel.org, thomas.petazzoni@bootlin.com, davem@davemloft.net, nadavh@marvell.com, ymarkman@marvell.com, linux-kernel@vger.kernel.org, kuba@kernel.org, linux@armlinux.org.uk, mw@semihalf.com, rmk+kernel@armlinux.org.uk, atenart@kernel.org Subject: Re: [PATCH RFC net-next 18/19] net: mvpp2: add ring size validation before enabling FC Message-ID: References: <1610292623-15564-1-git-send-email-stefanc@marvell.com> <1610292623-15564-19-git-send-email-stefanc@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1610292623-15564-19-git-send-email-stefanc@marvell.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, Jan 10, 2021 at 05:30:22PM +0200, stefanc@marvell.com wrote: > From: Stefan Chulski > > This patch add ring size validation before enabling FC. > 1. Flow control cannot be enabled if ring size is below start > threshold. > 2. Flow control disabled if ring size set below start > threshold. You should also tell phylink if pause is not supported, so it can change what is auto-negotiated, letting the link partner know. Andrew