From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ADA1C4361B for ; Sat, 12 Dec 2020 11:41:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1F97522C7D for ; Sat, 12 Dec 2020 11:41:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438333AbgLLLkv (ORCPT ); Sat, 12 Dec 2020 06:40:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57978 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726725AbgLLLku (ORCPT ); Sat, 12 Dec 2020 06:40:50 -0500 X-Greylist: delayed 1027 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Sat, 12 Dec 2020 03:40:10 PST Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [IPv6:2001:780:45:1d:225:90ff:fe52:c662]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8BA22C0613CF for ; Sat, 12 Dec 2020 03:40:10 -0800 (PST) Received: from uucp by ganesha.gnumonks.org with local-bsmtp (Exim 4.89) (envelope-from ) id 1ko2zN-0007nf-Ca; Sat, 12 Dec 2020 12:23:01 +0100 Received: from laforge by localhost.localdomain with local (Exim 4.94) (envelope-from ) id 1ko2zF-003sUY-Ub; Sat, 12 Dec 2020 12:22:53 +0100 Date: Sat, 12 Dec 2020 12:22:53 +0100 From: Harald Welte To: Jonas Bonn Cc: netdev@vger.kernel.org, pablo@netfilter.org Subject: Re: [PATCH net-next v2 10/12] gtp: add IPv6 support Message-ID: References: <20201211122612.869225-1-jonas@norrbonn.se> <20201211122612.869225-11-jonas@norrbonn.se> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201211122612.869225-11-jonas@norrbonn.se> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Jonas, thanks again for your patches, they are very much appreciated. However, I don't think that it is "that easy". PDP contexts (at least) in GPRS/EDGE and UMTS come in three flavors: * IPv4 only * IPv6 only * IPv4v6 (i.e. both an IPv4 and an IPv6 address within the same tunnel) See for example osmo-ggsn at https://git.osmocom.org/osmo-ggsn for an userspace implementation that covers all three cases, as well as a related automatic test suite containing cases for all three flavors at https://git.osmocom.org/osmo-ttcn3-hacks/tree/ggsn_tests If I read your patch correctly On Fri, Dec 11, 2020 at 01:26:10PM +0100, Jonas Bonn wrote: > - struct in_addr ms_addr_ip4; > - struct in_addr peer_addr_ip4; > + struct in6_addr ms_addr; > + struct in6_addr peer_addr; this simply replaces the (inner) IPv4 "MS addr" with an IPv6 "MS addr". Sure, it is an improvement over v4-only. But IMHO any follow-up change to introduce v4v6 PDP contexts would require significant changes, basically re-introducing the ms_add_ip4 member which you are removing here. Therefore, I argue very much in favor of intrducing proper IPv6 support (including v4v6) in one go. Regards, Harald -- - Harald Welte http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)