From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FBB2C4361B for ; Mon, 14 Dec 2020 21:21:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EA0212247F for ; Mon, 14 Dec 2020 21:21:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2503598AbgLNVU4 (ORCPT ); Mon, 14 Dec 2020 16:20:56 -0500 Received: from smtp-outgoing.laposte.net ([160.92.124.100]:54904 "EHLO smtp-outgoing.laposte.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2503568AbgLNVUk (ORCPT ); Mon, 14 Dec 2020 16:20:40 -0500 X-mail-filterd: {"version":"1.2.0","queueID":"4CvvKR2gWjz10MQR","contextId":"fc9c9fcb-86e0-4e10-9782-1a89285274a9"} Received: from outgoing-mail.laposte.net (localhost.localdomain [127.0.0.1]) by mlpnf0120.laposte.net (SMTP Server) with ESMTP id 4CvvKR2gWjz10MQR; Mon, 14 Dec 2020 22:14:35 +0100 (CET) X-mail-filterd: {"version":"1.2.0","queueID":"4CvvKR19xlz10MQQ","contextId":"08deaf0b-0861-4074-9b43-d33f7839d2a2"} X-lpn-mailing: LEGIT X-lpn-spamrating: 36 X-lpn-spamlevel: not-spam X-lpn-spamcause: OK, (-100)(0000)gggruggvucftvghtrhhoucdtuddrgedujedrudekkedgudegjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfntefrqffuvffgpdfqfgfvpdggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpeffhffvuffkfhggtggugfgjsehtkedttddttddunecuhfhrohhmpeggihhntggvnhhtucfuthgvhhhlrocuoehvihhntggvnhhtrdhsthgvhhhlvgeslhgrphhoshhtvgdrnhgvtheqnecuggftrfgrthhtvghrnhepffdtteetvedujeettdetleehhfehjefhueefhfeijeffleehuedugeegiefgffdtnecukfhppeekkedruddvuddrudegledrgeelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehhvghloheprhhomhhurghlugdrsggvrhhgvghrihgvpdhinhgvthepkeekrdduvddurddugeelrdegledpmhgrihhlfhhrohhmpehvihhntggvnhhtrdhsthgvhhhlvgeslhgrphhoshhtvgdrnhgvthdprhgtphhtthhopegurghvvghmsegurghvvghmlhhofhhtrdhnvghtpdhrtghpthhtohepkhhusggrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehjfihisehlihhnuhigrdhisghmrdgtohhmpdhrtghpthhtohepfhhlohhrihgrnhdrfhgrihhnvghllhhisehtvghlvggtohhmihhnthdrvghupdhrtghpthhtoheplhhinhhugidqkhgvrhhnvghlsehvghgvrhdrk hgvrhhnvghlrdhorhhgpdhrtghpthhtohepnhgvthguvghvsehvghgvrhdrkhgvrhhnvghlrdhorhhg Received: from romuald.bergerie (unknown [88.121.149.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mlpnf0120.laposte.net (SMTP Server) with ESMTPSA id 4CvvKR19xlz10MQQ; Mon, 14 Dec 2020 22:14:34 +0100 (CET) Received: by romuald.bergerie (Postfix, from userid 1000) id 959EC3DFA8F4; Mon, 14 Dec 2020 22:14:34 +0100 (CET) Date: Mon, 14 Dec 2020 22:14:34 +0100 From: Vincent =?iso-8859-1?Q?Stehl=E9?= To: Julian Wiedmann Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Florian Fainelli Subject: Re: [PATCH] net: korina: remove busy skb free Message-ID: Mail-Followup-To: Julian Wiedmann , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" , Jakub Kicinski , Florian Fainelli References: <20201213172052.12433-1-vincent.stehle@laposte.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=laposte.net; s=lpn-wlmd; t=1607980476; bh=FhA1NzlZW79MJc0KRvXihr5YWiW7pvjBdcRnaFAgDJY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To:Content-Transfer-Encoding; b=isJoemRoXZAwcDrK2OKoGo/LJNfzFuJiv1cqxE6nqRcO/fzkHocdpeTJxdB/RBHPifoudRHBx/kOK+1xk/uYWRSkdPnJSt9Di4D+UYVM4ME+iQWPwi70tVI+JmDUBLzDUi+4JyedtGTR0Sa+bQEkEUXqjf9ahYeXhLgK2XQACQpEz2adUzITu8ExjlNBIAPfAtnSjtTQMhOBjBvG34sMr1sTQf8OlJO5cxNDXheXMw6DFawaX4cQMawaB0O6vL/WPMvR4JpJjDxYby59ea8R6vfnrrAdaKleM5vufAAkP1yLol+ECmybxlLRMtyt0lqxJ0UjC2yhuF6yu69G8UYMGw==; Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Dec 14, 2020 at 11:03:12AM +0100, Julian Wiedmann wrote: > On 13.12.20 18:20, Vincent Stehl=E9 wrote: ... > > @@ -216,7 +216,6 @@ static int korina_send_packet(struct sk_buff *skb= , struct net_device *dev) > > netif_stop_queue(dev); > > else { > > dev->stats.tx_dropped++; > > - dev_kfree_skb_any(skb); > > spin_unlock_irqrestore(&lp->lock, flags); > > =20 > > return NETDEV_TX_BUSY; > >=20 >=20 > As this skb is returned to the stack (and not dropped), the tx_dropped > statistics increment looks bogus too. Hi Julian, Thanks for the review. I will respin the patch to remove the statistics increment as well. Best regards, Vincent.