From: James Morris <jmorris@namei.org>
To: Paul Moore <paul.moore@hp.com>
Cc: Valdis.Kletnieks@vt.edu, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, sds@tycho.nsa.gov,
netdev@vger.kernel.org
Subject: Re: 2.6.24-rc6-mm1 - git-lblnet.patch and networking horkage
Date: Tue, 1 Jan 2008 08:46:09 +1100 (EST) [thread overview]
Message-ID: <Xine.LNX.4.64.0801010841060.25768@us.intercode.com.au> (raw)
In-Reply-To: <200712311506.15230.paul.moore@hp.com>
On Mon, 31 Dec 2007, Paul Moore wrote:
> I'm pretty certain this is an uninitialized value problem now and not a
> use-after-free issue. The invalid/garbage ->iif value seems to only happen
> on packets that are generated locally and sent back into the stack for local
> consumption, e.g. loopback. These local packets also need to have been
> cloned at some point, either on the output or input path.
I think we need to find out exactly what's happening, first.
> The problem appears to be a skb_clone() function which does not clear the skb
> structure properly and fails to copy the ->iif value from the original skb to
> the cloned skb. From what I can tell, there are two possible solutions to
> this problem:
>
> 1. Clear all of the cloned skb fields in skb_clone() via memset()
Sounds like it's not going to fly for performance reasons in any case.
> 2. Copy the ->iif field in __copy_skb_header()
Seems valid.
- James
--
James Morris
<jmorris@namei.org>
next prev parent reply other threads:[~2007-12-31 21:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <3281504256.5618888@mail.hp.com>
[not found] ` <Xine.LNX.4.64.0712270848260.19279@us.intercode.com.au>
[not found] ` <200712311213.32515.paul.moore@hp.com>
2007-12-31 20:06 ` 2.6.24-rc6-mm1 - git-lblnet.patch and networking horkage Paul Moore
2007-12-31 21:46 ` James Morris [this message]
2007-12-31 22:01 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Xine.LNX.4.64.0801010841060.25768@us.intercode.com.au \
--to=jmorris@namei.org \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).