From: James Morris <jmorris@namei.org>
To: Paul Moore <paul.moore@hp.com>
Cc: Adrian Bunk <bunk@kernel.org>,
sds@tycho.nsa.gov, eparis@parisplace.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] selinux/netlabel.c should #include "netlabel.h"
Date: Thu, 28 Feb 2008 09:16:18 +1100 (EST) [thread overview]
Message-ID: <Xine.LNX.4.64.0802280916020.19162@us.intercode.com.au> (raw)
In-Reply-To: <200802271642.57556.paul.moore@hp.com>
On Wed, 27 Feb 2008, Paul Moore wrote:
> On Wednesday 27 February 2008 4:20:42 pm Adrian Bunk wrote:
> > Every file should include the headers containing the externs for its
> > global code.
> >
> > Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> It doesn't _need_ the file in the strictest sense, the header file is
> just there for the core SELinux code to call into the NetLabel/SELinux
> glue code (what is in security/selinux/netlabel.c). However, if this
> is to conform better to kernel coding policy (I assume that is the case
> here?) then that is fine with me.
>
> Acked-by: Paul Moore <paul.moore@hp.com>
Applied to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/selinux-2.6.git#next
--
James Morris
<jmorris@namei.org>
prev parent reply other threads:[~2008-02-27 22:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 21:20 [2.6 patch] selinux/netlabel.c should #include "netlabel.h" Adrian Bunk
2008-02-27 21:42 ` Paul Moore
2008-02-27 21:55 ` Adrian Bunk
2008-02-27 22:08 ` Paul Moore
2008-02-27 22:16 ` James Morris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Xine.LNX.4.64.0802280916020.19162@us.intercode.com.au \
--to=jmorris@namei.org \
--cc=bunk@kernel.org \
--cc=eparis@parisplace.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).