From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Vladimir Oltean <olteanv@gmail.com>
Cc: Angelo Dureghello <angelo@kernel-space.org>,
Andrew Lunn <andrew@lunn.ch>,
netdev@vger.kernel.org
Subject: Re: mv88e6321, dual cpu port
Date: Sat, 18 Feb 2023 13:56:54 +0000 [thread overview]
Message-ID: <Y/DZJmn4OfVA+hRq@shell.armlinux.org.uk> (raw)
In-Reply-To: <20230218133036.ec3fsaefs5jn7l7f@skbuf>
On Sat, Feb 18, 2023 at 03:30:36PM +0200, Vladimir Oltean wrote:
> On Thu, Feb 16, 2023 at 07:39:11PM +0100, Angelo Dureghello wrote:
> > I have a last issue, migrating from 5.4.70,
> > in 5.15.32 i have this error for both sfp cages:
> >
> > # [ 45.860784] mv88e6085 5b040000.ethernet-1:1d: p0: phylink_mac_link_state() failed: -95
> > [ 45.860814] mv88e6085 5b040000.ethernet-1:1d: p0: phylink_mac_link_state() failed: -95
> > [ 49.093371] mv88e6085 5b040000.ethernet-1:1d: p1: phylink_mac_link_state() failed: -95
> > [ 49.093400] mv88e6085 5b040000.ethernet-1:1d: p1: phylink_mac_link_state() failed: -95
> >
> > Is seems related to the fact that i am in in-band-status,
> > but 6321 has not serdes_pcs_get_state() op.
> >
> > How can i fix this ?
> >
> > Thanks !
> > --
> > Angelo Dureghello
>
> Looking at mv88e6321_ops in the latest net-next and in 5.4, I see no
> serdes ops implemented in net-next. OTOH, in 5.4, the equivalent of the
> current .serdes_pcs_get_state() which is now missing was .port_link_state().
> In 5.4, mv88e6321_ops had .port_link_state() set to mv88e6352_port_link_state(),
> but this got deleted with commit dc745ece3bd5 ("net: dsa: mv88e6xxx:
> remove port_link_state functions") and seemingly was not replaced with
> anything for 6321.
>
> I don't actually know how this is supposed to work. Maybe Russell King can help?
I've no idea offhand, and as today I feel utterly shit due to post-
Covid, I'm not going to be able to sort through and work out what
happened for a few days. Sorry. I'll try to look at it next week
provided I feel better.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2023-02-18 13:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-09 20:40 mv88e6321, dual cpu port Angelo Dureghello
2023-01-09 21:33 ` Andrew Lunn
2023-01-10 10:23 ` Angelo Dureghello
2023-01-10 22:22 ` Vladimir Oltean
2023-01-10 23:02 ` Andrew Lunn
2023-01-23 8:52 ` Angelo Dureghello
2023-01-23 11:28 ` Vladimir Oltean
2023-01-23 13:26 ` Angelo Dureghello
2023-01-23 19:18 ` Vladimir Oltean
2023-01-23 20:08 ` Andrew Lunn
2023-01-24 7:21 ` Angelo Dureghello
2023-01-24 11:41 ` Vladimir Oltean
2023-01-24 13:57 ` Andrew Lunn
2023-01-25 9:04 ` Angelo Dureghello
2023-02-06 10:43 ` Angelo Dureghello
2023-02-06 13:24 ` Andrew Lunn
2023-02-16 11:20 ` Angelo Dureghello
2023-02-16 12:50 ` Vladimir Oltean
2023-02-16 12:59 ` Andrew Lunn
2023-02-16 15:31 ` Vladimir Oltean
2023-02-16 18:39 ` Angelo Dureghello
2023-02-18 13:30 ` Vladimir Oltean
2023-02-18 13:56 ` Russell King (Oracle) [this message]
2023-02-16 14:24 ` Angelo Dureghello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/DZJmn4OfVA+hRq@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=angelo@kernel-space.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).