From: Andrew Lunn <andrew@lunn.ch>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH net-next v1 4/4] net: phy: c45: genphy_c45_ethtool_set_eee: validate EEE link modes
Date: Mon, 20 Feb 2023 16:34:57 +0100 [thread overview]
Message-ID: <Y/OTIQPmSaKAMchT@lunn.ch> (raw)
In-Reply-To: <20230220135605.1136137-5-o.rempel@pengutronix.de>
> + adv[0] = data->advertised;
Same here please.
> + linkmode_andnot(adv, adv, phydev->supported_eee);
> + if (!linkmode_empty(adv)) {
> + phydev_warn(phydev, "At least some EEE link modes are not supported.\n");
> + return -EINVAL;
> + }
> +
> phydev->advertising_eee[0] = data->advertised;
...
Andrew
prev parent reply other threads:[~2023-02-20 15:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 13:56 [PATCH net-next v1 0/4] net: phy: EEE fixes Oleksij Rempel
2023-02-20 13:56 ` [PATCH net-next v1 1/4] net: phy: c45: use "supported_eee" instead of supported for access validation Oleksij Rempel
2023-02-20 14:09 ` Russell King (Oracle)
2023-02-20 13:56 ` [PATCH net-next v1 2/4] net: phy: c45: add genphy_c45_an_config_eee_aneg() function Oleksij Rempel
2023-02-20 14:10 ` Russell King (Oracle)
2023-02-20 13:56 ` [PATCH net-next v1 3/4] net: phy: do not force EEE support Oleksij Rempel
2023-02-20 14:18 ` Russell King (Oracle)
2023-02-20 15:08 ` Oleksij Rempel
2023-02-20 15:32 ` Andrew Lunn
2023-02-20 14:21 ` Russell King (Oracle)
2023-02-20 15:07 ` Oleksij Rempel
2023-02-20 15:48 ` Andrew Lunn
2023-02-20 16:13 ` Oleksij Rempel
2023-02-20 17:24 ` Russell King (Oracle)
2023-02-20 17:27 ` Russell King (Oracle)
2023-02-20 15:43 ` Andrew Lunn
2023-02-20 13:56 ` [PATCH net-next v1 4/4] net: phy: c45: genphy_c45_ethtool_set_eee: validate EEE link modes Oleksij Rempel
2023-02-20 15:34 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/OTIQPmSaKAMchT@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).