From: Andrew Lunn <andrew@lunn.ch>
To: Li Yang <leoyang.li@nxp.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Luo Jie <luoj@codeaurora.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Viorel Suman <viorel.suman@nxp.com>, Wei Fang <wei.fang@nxp.com>
Subject: Re: [PATCH] net: phy: at803x: fix the wol setting functions
Date: Tue, 21 Feb 2023 23:56:44 +0100 [thread overview]
Message-ID: <Y/VMLF0NGgO1F34K@lunn.ch> (raw)
In-Reply-To: <20230221224031.7244-1-leoyang.li@nxp.com>
On Tue, Feb 21, 2023 at 04:40:31PM -0600, Li Yang wrote:
> In 7beecaf7d507 ("net: phy: at803x: improve the WOL feature"), it seems
> not correct to use a wol_en bit in a 1588 Control Register which is only
> available on AR8031/AR8033(share the same phy_id) to determine if WoL is
> enabled. Change it back to use AT803X_INTR_ENABLE_WOL for determining
> the WoL status which is applicable on all chips supporting wol. Also
> update the at803x_set_wol() function to only update the 1588 register on
> chips having it.
> After this change, disabling wol at probe from
> d7cd5e06c9dd ("net: phy: at803x: disable WOL at probe") is no longer
> needed. So it is removed.
Rather than remove it, please git revert it, and explain in the commit
message why.
>
> Also remove the set_wol()/get_wol() callbacks from AR8032 which doesn't
> support WoL.
This change was part of 5800091a2061 ("net: phy: at803x: add support for AR8032 PHY")
Please break this patch up into individual fixes. The different fixes
might need different levels of backporting etc.
Andrew
next prev parent reply other threads:[~2023-02-21 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 22:40 [PATCH] net: phy: at803x: fix the wol setting functions Li Yang
2023-02-21 22:56 ` Andrew Lunn [this message]
2023-02-21 23:02 ` Leo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/VMLF0NGgO1F34K@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=luoj@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=viorel.suman@nxp.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox