* [PATCH -next] net/mlx5: Remove NULL check before dev_{put, hold}
@ 2023-02-22 2:29 Yang Li
2023-02-22 9:34 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2023-02-22 2:29 UTC (permalink / raw)
To: kuba
Cc: davem, saeedm, leon, edumazet, pabeni, netdev, linux-rdma,
linux-kernel, Yang Li, Abaci Robot
The call netdev_{put, hold} of dev_{put, hold} will check NULL,
so there is no need to check before using dev_{put, hold},
remove it to silence the warning：
./drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c:714:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4174
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c
index e24b46953542..8f7452dc00ee 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c
@@ -710,8 +710,7 @@ void mlx5e_rep_tc_receive(struct mlx5_cqe64 *cqe, struct mlx5e_rq *rq,
else
napi_gro_receive(rq->cq.napi, skb);
- if (tc_priv.fwd_dev)
- dev_put(tc_priv.fwd_dev);
+ dev_put(tc_priv.fwd_dev);
return;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] net/mlx5: Remove NULL check before dev_{put, hold}
2023-02-22 2:29 [PATCH -next] net/mlx5: Remove NULL check before dev_{put, hold} Yang Li
@ 2023-02-22 9:34 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2023-02-22 9:34 UTC (permalink / raw)
To: Yang Li
Cc: kuba, davem, saeedm, edumazet, pabeni, netdev, linux-rdma,
linux-kernel, Abaci Robot
On Wed, Feb 22, 2023 at 10:29:44AM +0800, Yang Li wrote:
> The call netdev_{put, hold} of dev_{put, hold} will check NULL,
> so there is no need to check before using dev_{put, hold},
> remove it to silence the warning：
>
> ./drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c:714:2-9: WARNING: NULL check before dev_{put, hold} functions is not needed.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4174
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/en/rep/tc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Please submit this patch with fixed title from -next to be net-next
after merge window.
Thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-02-22 9:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-22 2:29 [PATCH -next] net/mlx5: Remove NULL check before dev_{put, hold} Yang Li
2023-02-22 9:34 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).