* Re: [PATCH 00/13] Rename k[v]free_rcu() single argument to k[v]free_rcu_mightsleep() [not found] ` <20230223155415.GA2948950@paulmck-ThinkPad-P17-Gen-1> @ 2023-02-23 16:21 ` Julian Anastasov 2023-02-23 17:14 ` Paul E. McKenney 0 siblings, 1 reply; 4+ messages in thread From: Julian Anastasov @ 2023-02-23 16:21 UTC (permalink / raw) To: Paul E. McKenney Cc: Zhuo, Qiuxu, Frederic Weisbecker, Uladzislau Rezki (Sony), LKML, RCU, Oleksiy Avramchenko, Jens Axboe, Philipp Reisner, Bryan Tan, Steven Rostedt, Eric Dumazet, Bob Pearson, Ariel Levkovich, Theodore Ts'o, pablo, netdev [-- Attachment #1: Type: text/plain, Size: 1217 bytes --] Hello, On Thu, 23 Feb 2023, Paul E. McKenney wrote: > > > Not sure if you guys noticed but on latest rcu/dev: > > > > > > net/netfilter/ipvs/ip_vs_est.c: In function ‘ip_vs_stop_estimator’: > > > net/netfilter/ipvs/ip_vs_est.c:552:15: error: macro "kfree_rcu" requires 2 > > > arguments, but only 1 given > > > kfree_rcu(td); > > > ^ > > > net/netfilter/ipvs/ip_vs_est.c:552:3: error: ‘kfree_rcu’ undeclared (first use in > > > this function); did you mean ‘kfree_skb’? > > > kfree_rcu(td); > > > ^~~~~~~~~ > > > kfree_skb > > > net/netfilter/ipvs/ip_vs_est.c:552:3: note: each undeclared identifier is > > > reported only once for each function it appears in > > > > Hi Frederic Weisbecker, > > > > I encountered the same build error as yours. > > Per the discussion link below, the fix for this build error by Uladzislau Rezki will be picked up by some other maintainer's branch? > > @Paul E . McKenney, please correct me if my understanding is wrong. 😊 > > > > https://lore.kernel.org/rcu/Y9qc+lgR1CgdszKs@salvia/ > > Pablo and Julian, how are things coming with that patch? Fix is already in net and net-next tree Regards -- Julian Anastasov <ja@ssi.bg> ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 00/13] Rename k[v]free_rcu() single argument to k[v]free_rcu_mightsleep() 2023-02-23 16:21 ` [PATCH 00/13] Rename k[v]free_rcu() single argument to k[v]free_rcu_mightsleep() Julian Anastasov @ 2023-02-23 17:14 ` Paul E. McKenney 2023-02-23 17:36 ` Pablo Neira Ayuso 0 siblings, 1 reply; 4+ messages in thread From: Paul E. McKenney @ 2023-02-23 17:14 UTC (permalink / raw) To: Julian Anastasov Cc: Zhuo, Qiuxu, Frederic Weisbecker, Uladzislau Rezki (Sony), LKML, RCU, Oleksiy Avramchenko, Jens Axboe, Philipp Reisner, Bryan Tan, Steven Rostedt, Eric Dumazet, Bob Pearson, Ariel Levkovich, Theodore Ts'o, pablo, netdev On Thu, Feb 23, 2023 at 06:21:46PM +0200, Julian Anastasov wrote: > > Hello, > > On Thu, 23 Feb 2023, Paul E. McKenney wrote: > > > > > Not sure if you guys noticed but on latest rcu/dev: > > > > > > > > net/netfilter/ipvs/ip_vs_est.c: In function ‘ip_vs_stop_estimator’: > > > > net/netfilter/ipvs/ip_vs_est.c:552:15: error: macro "kfree_rcu" requires 2 > > > > arguments, but only 1 given > > > > kfree_rcu(td); > > > > ^ > > > > net/netfilter/ipvs/ip_vs_est.c:552:3: error: ‘kfree_rcu’ undeclared (first use in > > > > this function); did you mean ‘kfree_skb’? > > > > kfree_rcu(td); > > > > ^~~~~~~~~ > > > > kfree_skb > > > > net/netfilter/ipvs/ip_vs_est.c:552:3: note: each undeclared identifier is > > > > reported only once for each function it appears in > > > > > > Hi Frederic Weisbecker, > > > > > > I encountered the same build error as yours. > > > Per the discussion link below, the fix for this build error by Uladzislau Rezki will be picked up by some other maintainer's branch? > > > @Paul E . McKenney, please correct me if my understanding is wrong. 😊 > > > > > > https://lore.kernel.org/rcu/Y9qc+lgR1CgdszKs@salvia/ > > > > Pablo and Julian, how are things coming with that patch? > > Fix is already in net and net-next tree Very good, thank you! Is this going into this merge window or is it expected to wait for v6.4? Thanx, Paul ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 00/13] Rename k[v]free_rcu() single argument to k[v]free_rcu_mightsleep() 2023-02-23 17:14 ` Paul E. McKenney @ 2023-02-23 17:36 ` Pablo Neira Ayuso 2023-02-23 18:21 ` Paul E. McKenney 0 siblings, 1 reply; 4+ messages in thread From: Pablo Neira Ayuso @ 2023-02-23 17:36 UTC (permalink / raw) To: Paul E. McKenney Cc: Julian Anastasov, Zhuo, Qiuxu, Frederic Weisbecker, Uladzislau Rezki (Sony), LKML, RCU, Oleksiy Avramchenko, Jens Axboe, Philipp Reisner, Bryan Tan, Steven Rostedt, Eric Dumazet, Bob Pearson, Ariel Levkovich, Theodore Ts'o, netdev On Thu, Feb 23, 2023 at 09:14:32AM -0800, Paul E. McKenney wrote: > On Thu, Feb 23, 2023 at 06:21:46PM +0200, Julian Anastasov wrote: > > > > Hello, > > > > On Thu, 23 Feb 2023, Paul E. McKenney wrote: > > > > > > > Not sure if you guys noticed but on latest rcu/dev: > > > > > > > > > > net/netfilter/ipvs/ip_vs_est.c: In function ‘ip_vs_stop_estimator’: > > > > > net/netfilter/ipvs/ip_vs_est.c:552:15: error: macro "kfree_rcu" requires 2 > > > > > arguments, but only 1 given > > > > > kfree_rcu(td); > > > > > ^ > > > > > net/netfilter/ipvs/ip_vs_est.c:552:3: error: ‘kfree_rcu’ undeclared (first use in > > > > > this function); did you mean ‘kfree_skb’? > > > > > kfree_rcu(td); > > > > > ^~~~~~~~~ > > > > > kfree_skb > > > > > net/netfilter/ipvs/ip_vs_est.c:552:3: note: each undeclared identifier is > > > > > reported only once for each function it appears in > > > > > > > > Hi Frederic Weisbecker, > > > > > > > > I encountered the same build error as yours. > > > > Per the discussion link below, the fix for this build error by Uladzislau Rezki will be picked up by some other maintainer's branch? > > > > @Paul E . McKenney, please correct me if my understanding is wrong. 😊 > > > > > > > > https://lore.kernel.org/rcu/Y9qc+lgR1CgdszKs@salvia/ > > > > > > Pablo and Julian, how are things coming with that patch? > > > > Fix is already in net and net-next tree > > Very good, thank you! Is this going into this merge window or is it > expected to wait for v6.4? this merge window. Thanx, Paul ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 00/13] Rename k[v]free_rcu() single argument to k[v]free_rcu_mightsleep() 2023-02-23 17:36 ` Pablo Neira Ayuso @ 2023-02-23 18:21 ` Paul E. McKenney 0 siblings, 0 replies; 4+ messages in thread From: Paul E. McKenney @ 2023-02-23 18:21 UTC (permalink / raw) To: Pablo Neira Ayuso Cc: Julian Anastasov, Zhuo, Qiuxu, Frederic Weisbecker, Uladzislau Rezki (Sony), LKML, RCU, Oleksiy Avramchenko, Jens Axboe, Philipp Reisner, Bryan Tan, Steven Rostedt, Eric Dumazet, Bob Pearson, Ariel Levkovich, Theodore Ts'o, netdev On Thu, Feb 23, 2023 at 06:36:26PM +0100, Pablo Neira Ayuso wrote: > On Thu, Feb 23, 2023 at 09:14:32AM -0800, Paul E. McKenney wrote: > > On Thu, Feb 23, 2023 at 06:21:46PM +0200, Julian Anastasov wrote: > > > > > > Hello, > > > > > > On Thu, 23 Feb 2023, Paul E. McKenney wrote: > > > > > > > > > Not sure if you guys noticed but on latest rcu/dev: > > > > > > > > > > > > net/netfilter/ipvs/ip_vs_est.c: In function ‘ip_vs_stop_estimator’: > > > > > > net/netfilter/ipvs/ip_vs_est.c:552:15: error: macro "kfree_rcu" requires 2 > > > > > > arguments, but only 1 given > > > > > > kfree_rcu(td); > > > > > > ^ > > > > > > net/netfilter/ipvs/ip_vs_est.c:552:3: error: ‘kfree_rcu’ undeclared (first use in > > > > > > this function); did you mean ‘kfree_skb’? > > > > > > kfree_rcu(td); > > > > > > ^~~~~~~~~ > > > > > > kfree_skb > > > > > > net/netfilter/ipvs/ip_vs_est.c:552:3: note: each undeclared identifier is > > > > > > reported only once for each function it appears in > > > > > > > > > > Hi Frederic Weisbecker, > > > > > > > > > > I encountered the same build error as yours. > > > > > Per the discussion link below, the fix for this build error by Uladzislau Rezki will be picked up by some other maintainer's branch? > > > > > @Paul E . McKenney, please correct me if my understanding is wrong. 😊 > > > > > > > > > > https://lore.kernel.org/rcu/Y9qc+lgR1CgdszKs@salvia/ > > > > > > > > Pablo and Julian, how are things coming with that patch? > > > > > > Fix is already in net and net-next tree > > > > Very good, thank you! Is this going into this merge window or is it > > expected to wait for v6.4? > > this merge window. Thanx, Paul Thank you, and looking forward to it! Thanx, Paul ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-23 18:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230201150815.409582-1-urezki@gmail.com>
[not found] ` <Y/df4xtTQ14w/2m4@lothringen>
[not found] ` <IA1PR11MB6171CE257AC58265B8B7CC9889AB9@IA1PR11MB6171.namprd11.prod.outlook.com>
[not found] ` <20230223155415.GA2948950@paulmck-ThinkPad-P17-Gen-1>
2023-02-23 16:21 ` [PATCH 00/13] Rename k[v]free_rcu() single argument to k[v]free_rcu_mightsleep() Julian Anastasov
2023-02-23 17:14 ` Paul E. McKenney
2023-02-23 17:36 ` Pablo Neira Ayuso
2023-02-23 18:21 ` Paul E. McKenney
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox