From: Martin Habets <habetsm.xilinx@gmail.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "Íñigo Huguet" <ihuguet@redhat.com>,
"Vadim Fedorenko" <vadim.fedorenko@linux.dev>,
ecree.xilinx@gmail.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
"Yalin Li" <yalli@redhat.com>
Subject: Re: [PATCH net-next v4 3/4] sfc: support unicast PTP
Date: Fri, 24 Feb 2023 09:01:59 +0000 [thread overview]
Message-ID: <Y/h8w80liiVmw3Ap@gmail.com> (raw)
In-Reply-To: <Y/ZIXRf1LEMBsV9r@hoboy.vegasvil.org>
On Wed, Feb 22, 2023 at 08:52:45AM -0800, Richard Cochran wrote:
> On Wed, Feb 22, 2023 at 03:41:51PM +0100, Íñigo Huguet wrote:
>
> > The reason is explained in a comment in efx_ptp_insert_multicast filters:
> > Must filter on both event and general ports to ensure
> > that there is no packet re-ordering
>
> There is nothing wrong with re-ordering.
I disagree. If re-ordering can be avoided that is a good thing.
> Nothing guarantees that
> datagrams are received in the order they are sent.
True, but they usually are.
> The user space PTP stack must be handle out of order messages correct
> (which ptp4l does do BTW).
This takes CPU time. If it can be avoided that is a good thing, as
it puts less pressure on the host. It is not just about CPU load, it
is also about latency.
Martin
next prev parent reply other threads:[~2023-02-24 9:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 12:52 [PATCH net-next v4 0/4] sfc: support unicast PTP Íñigo Huguet
2023-02-21 12:52 ` [PATCH net-next v4 1/4] sfc: store PTP filters in a list Íñigo Huguet
2023-02-21 12:52 ` [PATCH net-next v4 2/4] sfc: allow insertion of filters for unicast PTP Íñigo Huguet
2023-02-21 12:52 ` [PATCH net-next v4 3/4] sfc: support " Íñigo Huguet
2023-02-22 14:20 ` Vadim Fedorenko
2023-02-22 14:41 ` Íñigo Huguet
2023-02-22 16:52 ` Richard Cochran
2023-02-23 13:08 ` Íñigo Huguet
2023-02-24 9:01 ` Martin Habets [this message]
2023-02-24 15:43 ` Richard Cochran
2023-02-24 15:58 ` Richard Cochran
2023-02-21 12:52 ` [PATCH net-next v4 4/4] sfc: remove expired unicast PTP filters Íñigo Huguet
2023-02-21 16:25 ` [PATCH net-next v4 0/4] sfc: support unicast PTP Jakub Kicinski
2023-02-22 9:24 ` Martin Habets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y/h8w80liiVmw3Ap@gmail.com \
--to=habetsm.xilinx@gmail.com \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=ihuguet@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=vadim.fedorenko@linux.dev \
--cc=yalli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).