From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Temerkhanov, Sergey" <sergey.temerkhanov@intel.com>,
netdev@vger.kernel.org
Cc: Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH net-next] auxiliary: Implement refcounting
Date: Thu, 16 Feb 2023 14:02:02 +0100 [thread overview]
Message-ID: <Y+4pSlKeNHhD2nH2@kroah.com> (raw)
In-Reply-To: <Y+4kwf3SRq5NBzBz@unreal>
Oh, one more fun thing:
On Thu, Feb 16, 2023 at 02:42:41PM +0200, Leon Romanovsky wrote:
> On Thu, Feb 16, 2023 at 01:16:21PM +0100, Temerkhanov, Sergey wrote:
> > struct auxiliary_device {
> > struct device dev;
> > + refcount_t refcnt;
> > const char *name;
> > + struct wait_queue_head wq_head;
> > u32 id;
Sergey, you are adding an additional reference count to a structure that
is already properly reference counted! So you are imposing 2 different
counts and lifecycles on a single tiny structure? How is that even
supposed to work?
Again, please get reviews from internal Intel developers FIRST as is
required by all Intel kernel developers touching code like this. You
know this, it is part of your internal development rules, please do not
try to ignore them, that's a sure way to get everyone to just ignore
your changes going forward.
thanks,
greg k-h
prev parent reply other threads:[~2023-02-16 13:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 12:16 [PATCH net-next] auxiliary: Implement refcounting Temerkhanov, Sergey
2023-02-16 12:42 ` Leon Romanovsky
2023-02-16 12:59 ` Greg Kroah-Hartman
2023-02-16 13:02 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+4pSlKeNHhD2nH2@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sergey.temerkhanov@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).