From: Andrew Lunn <andrew@lunn.ch>
To: Yuiko.Oshino@microchip.com
Cc: enguerrand.de-ribaucourt@savoirfairelinux.com,
Woojung.Huh@microchip.com, hkallweit1@gmail.com,
netdev@vger.kernel.org, pabeni@redhat.com, davem@davemloft.net,
UNGLinuxDriver@microchip.com, linux@armlinux.org.uk,
edumazet@google.com, linux-usb@vger.kernel.org, kuba@kernel.org
Subject: Re: [PATCH net 1/2] net:usb:lan78xx: fix accessing the LAN7800's internal phy specific registers from the MAC driver
Date: Thu, 16 Feb 2023 17:56:27 +0100 [thread overview]
Message-ID: <Y+5gOxDuyK3csyre@lunn.ch> (raw)
In-Reply-To: <CH0PR11MB556166DDD69AD4D5FDCDB2F08EA09@CH0PR11MB5561.namprd11.prod.outlook.com>
> Hi Andrew,
>
> Enguerrand reported the below on 20 Dec 2022, therefore, submitting to net.
>
> " Some operations during the cable switch workaround modify the register
> LAN88XX_INT_MASK of the PHY. However, this register is specific to the
> LAN8835 PHY. For instance, if a DP8322I PHY is connected to the LAN7801,
> that register (0x19), corresponds to the LED and MAC address
> configuration, resulting in unapropriate behavior."
O.K.
So please include in the commit message this information. Then it
becomes clear it really is a fix.
Also, you did not add a fixes: tag to the second patch. There is a
danger the first patch gets back ported, but not the second. Since you
are just moving code around, i suggest you have just have one patch.
Andrew
next prev parent reply other threads:[~2023-02-16 16:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 14:20 [PATCH net 0/2] net:usb:lan78xx: move LAN7800 internal phy register accesses to the phy driver Yuiko Oshino
2023-02-16 14:20 ` [PATCH net 1/2] net:usb:lan78xx: fix accessing the LAN7800's internal phy specific registers from the MAC driver Yuiko Oshino
2023-02-16 15:08 ` Andrew Lunn
2023-02-16 15:20 ` Yuiko.Oshino
2023-02-16 16:56 ` Andrew Lunn [this message]
2023-02-16 18:30 ` Yuiko.Oshino
2023-02-16 14:20 ` [PATCH net 2/2] net:phy:microchip: " Yuiko Oshino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+5gOxDuyK3csyre@lunn.ch \
--to=andrew@lunn.ch \
--cc=UNGLinuxDriver@microchip.com \
--cc=Woojung.Huh@microchip.com \
--cc=Yuiko.Oshino@microchip.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enguerrand.de-ribaucourt@savoirfairelinux.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).