From: Jiri Pirko <jiri@resnulli.us>
To: Petr Machata <petrm@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Jacob Keller <jacob.e.keller@intel.com>,
Ido Schimmel <idosch@nvidia.com>, Jiri Pirko <jiri@nvidia.com>,
Danielle Ratson <danieller@nvidia.com>,
mlxsw@nvidia.com
Subject: Re: [PATCH net-next 1/6] mlxsw: spectrum: Remove pointless call to devlink_param_driverinit_value_set()
Date: Tue, 7 Feb 2023 08:39:11 +0100 [thread overview]
Message-ID: <Y+IAH9uhhcev9MXT@nanopsycho> (raw)
In-Reply-To: <bb8ddbeb644e9b631445515e338ecf1eef33587e.1675692666.git.petrm@nvidia.com>
Mon, Feb 06, 2023 at 04:39:18PM CET, petrm@nvidia.com wrote:
>From: Danielle Ratson <danieller@nvidia.com>
>
>The "acl_region_rehash_interval" devlink parameter is a "runtime"
>parameter, making the call to devl_param_driverinit_value_set()
>pointless. Before cited commit the function simply returned an error
>(that was not checked), but now it emits a WARNING [1].
>
>Fix by removing the function call.
>
>[1]
>WARNING: CPU: 0 PID: 7 at net/devlink/leftover.c:10974
>devl_param_driverinit_value_set+0x8c/0x90
>[...]
>Call Trace:
> <TASK>
> mlxsw_sp2_params_register+0x83/0xb0 [mlxsw_spectrum]
> __mlxsw_core_bus_device_register+0x5e5/0x990 [mlxsw_core]
> mlxsw_core_bus_device_register+0x42/0x60 [mlxsw_core]
> mlxsw_pci_probe+0x1f0/0x230 [mlxsw_pci]
> local_pci_probe+0x1a/0x40
> work_for_cpu_fn+0xf/0x20
> process_one_work+0x1db/0x390
> worker_thread+0x1d5/0x3b0
> kthread+0xe5/0x110
> ret_from_fork+0x1f/0x30
> </TASK>
>
>Fixes: 85fe0b324c83 ("devlink: make devlink_param_driverinit_value_set() return void")
>Signed-off-by: Danielle Ratson <danieller@nvidia.com>
>Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
>Signed-off-by: Petr Machata <petrm@nvidia.com>
next prev parent reply other threads:[~2023-02-07 7:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 15:39 [PATCH net-next 0/6] mlxsw: Misc devlink changes Petr Machata
2023-02-06 15:39 ` [PATCH net-next 1/6] mlxsw: spectrum: Remove pointless call to devlink_param_driverinit_value_set() Petr Machata
2023-02-07 7:39 ` Jiri Pirko [this message]
2023-02-06 15:39 ` [PATCH net-next 2/6] mlxsw: spectrum_acl_tcam: Add missing mutex_destroy() Petr Machata
2023-02-06 15:39 ` [PATCH net-next 3/6] mlxsw: spectrum_acl_tcam: Make fini symmetric to init Petr Machata
2023-02-06 15:39 ` [PATCH net-next 4/6] mlxsw: spectrum_acl_tcam: Reorder functions to avoid forward declarations Petr Machata
2023-02-06 15:39 ` [PATCH net-next 5/6] mlxsw: spectrum_acl_tcam: Move devlink param to TCAM code Petr Machata
2023-02-06 15:39 ` [PATCH net-next 6/6] mlxsw: core: Register devlink instance before sub-objects Petr Machata
2023-02-06 17:41 ` [PATCH net-next 0/6] mlxsw: Misc devlink changes Jacob Keller
2023-02-08 4:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+IAH9uhhcev9MXT@nanopsycho \
--to=jiri@resnulli.us \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox