* [PATCH 1/1] ice: add support BIG TCP on IPv6
@ 2023-02-06 15:59 Pawel Chmielewski
2023-02-06 16:53 ` [Intel-wired-lan] " Paul Menzel
2023-02-13 8:49 ` G, GurucharanX
0 siblings, 2 replies; 4+ messages in thread
From: Pawel Chmielewski @ 2023-02-06 15:59 UTC (permalink / raw)
To: netdev; +Cc: intel-wired-lan, Pawel Chmielewski
This change enables sending BIG TCP packets on IPv6 in the ice driver using
generic ipv6_hopopt_jumbo_remove helper for stripping HBH header.
Tested:
netperf -t TCP_RR -H 2001:db8:0:f101::1 -- -r80000,80000 -O MIN_LATENCY,P90_LATENCY,P99_LATENCY,THROUGHPUT
Results varied from one setup to another, but in every case we got lower
latencies and increased transactions rate.
Signed-off-by: Pawel Chmielewski <pawel.chmielewski@intel.com>
---
drivers/net/ethernet/intel/ice/ice.h | 2 ++
drivers/net/ethernet/intel/ice/ice_main.c | 2 ++
drivers/net/ethernet/intel/ice/ice_txrx.c | 3 +++
3 files changed, 7 insertions(+)
diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h
index 3d26ff4122e0..c774fdd482cd 100644
--- a/drivers/net/ethernet/intel/ice/ice.h
+++ b/drivers/net/ethernet/intel/ice/ice.h
@@ -122,6 +122,8 @@
#define ICE_MAX_MTU (ICE_AQ_SET_MAC_FRAME_SIZE_MAX - ICE_ETH_PKT_HDR_PAD)
+#define ICE_MAX_TSO_SIZE 131072
+
#define ICE_UP_TABLE_TRANSLATE(val, i) \
(((val) << ICE_AQ_VSI_UP_TABLE_UP##i##_S) & \
ICE_AQ_VSI_UP_TABLE_UP##i##_M)
diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
index 22b8ad058286..8c74a48ad0d3 100644
--- a/drivers/net/ethernet/intel/ice/ice_main.c
+++ b/drivers/net/ethernet/intel/ice/ice_main.c
@@ -3421,6 +3421,8 @@ static void ice_set_netdev_features(struct net_device *netdev)
* be changed at runtime
*/
netdev->hw_features |= NETIF_F_RXFCS;
+
+ netif_set_tso_max_size(netdev, ICE_MAX_TSO_SIZE);
}
/**
diff --git a/drivers/net/ethernet/intel/ice/ice_txrx.c b/drivers/net/ethernet/intel/ice/ice_txrx.c
index ccf09c957a1c..bef927afb766 100644
--- a/drivers/net/ethernet/intel/ice/ice_txrx.c
+++ b/drivers/net/ethernet/intel/ice/ice_txrx.c
@@ -2297,6 +2297,9 @@ ice_xmit_frame_ring(struct sk_buff *skb, struct ice_tx_ring *tx_ring)
ice_trace(xmit_frame_ring, tx_ring, skb);
+ if (unlikely(ipv6_hopopt_jumbo_remove(skb)))
+ goto out_drop;
+
count = ice_xmit_desc_count(skb);
if (ice_chk_linearize(skb, count)) {
if (__skb_linearize(skb))
--
2.37.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Intel-wired-lan] [PATCH 1/1] ice: add support BIG TCP on IPv6
2023-02-06 15:59 [PATCH 1/1] ice: add support BIG TCP on IPv6 Pawel Chmielewski
@ 2023-02-06 16:53 ` Paul Menzel
2023-02-07 16:26 ` Pawel Chmielewski
2023-02-13 8:49 ` G, GurucharanX
1 sibling, 1 reply; 4+ messages in thread
From: Paul Menzel @ 2023-02-06 16:53 UTC (permalink / raw)
To: Pawel Chmielewski; +Cc: netdev, intel-wired-lan
Dear Pawel,
Thank you for your patch.
Am 06.02.23 um 16:59 schrieb Pawel Chmielewski:
> This change enables sending BIG TCP packets on IPv6 in the ice driver using
> generic ipv6_hopopt_jumbo_remove helper for stripping HBH header.
>
> Tested:
> netperf -t TCP_RR -H 2001:db8:0:f101::1 -- -r80000,80000 -O MIN_LATENCY,P90_LATENCY,P99_LATENCY,THROUGHPUT
>
> Results varied from one setup to another, but in every case we got lower
> latencies and increased transactions rate.
Please give some concrete examples nevertheless.
Kind regards,
Paul
> Signed-off-by: Pawel Chmielewski <pawel.chmielewski@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice.h | 2 ++
> drivers/net/ethernet/intel/ice/ice_main.c | 2 ++
> drivers/net/ethernet/intel/ice/ice_txrx.c | 3 +++
> 3 files changed, 7 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h
> index 3d26ff4122e0..c774fdd482cd 100644
> --- a/drivers/net/ethernet/intel/ice/ice.h
> +++ b/drivers/net/ethernet/intel/ice/ice.h
> @@ -122,6 +122,8 @@
>
> #define ICE_MAX_MTU (ICE_AQ_SET_MAC_FRAME_SIZE_MAX - ICE_ETH_PKT_HDR_PAD)
>
> +#define ICE_MAX_TSO_SIZE 131072
> +
> #define ICE_UP_TABLE_TRANSLATE(val, i) \
> (((val) << ICE_AQ_VSI_UP_TABLE_UP##i##_S) & \
> ICE_AQ_VSI_UP_TABLE_UP##i##_M)
> diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> index 22b8ad058286..8c74a48ad0d3 100644
> --- a/drivers/net/ethernet/intel/ice/ice_main.c
> +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> @@ -3421,6 +3421,8 @@ static void ice_set_netdev_features(struct net_device *netdev)
> * be changed at runtime
> */
> netdev->hw_features |= NETIF_F_RXFCS;
> +
> + netif_set_tso_max_size(netdev, ICE_MAX_TSO_SIZE);
> }
>
> /**
> diff --git a/drivers/net/ethernet/intel/ice/ice_txrx.c b/drivers/net/ethernet/intel/ice/ice_txrx.c
> index ccf09c957a1c..bef927afb766 100644
> --- a/drivers/net/ethernet/intel/ice/ice_txrx.c
> +++ b/drivers/net/ethernet/intel/ice/ice_txrx.c
> @@ -2297,6 +2297,9 @@ ice_xmit_frame_ring(struct sk_buff *skb, struct ice_tx_ring *tx_ring)
>
> ice_trace(xmit_frame_ring, tx_ring, skb);
>
> + if (unlikely(ipv6_hopopt_jumbo_remove(skb)))
> + goto out_drop;
> +
> count = ice_xmit_desc_count(skb);
> if (ice_chk_linearize(skb, count)) {
> if (__skb_linearize(skb))
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Intel-wired-lan] [PATCH 1/1] ice: add support BIG TCP on IPv6
2023-02-06 16:53 ` [Intel-wired-lan] " Paul Menzel
@ 2023-02-07 16:26 ` Pawel Chmielewski
0 siblings, 0 replies; 4+ messages in thread
From: Pawel Chmielewski @ 2023-02-07 16:26 UTC (permalink / raw)
To: Paul Menzel; +Cc: netdev, intel-wired-lan
On Mon, Feb 06, 2023 at 05:53:00PM +0100, Paul Menzel wrote:
> Dear Pawel,
>
>
> Thank you for your patch.
>
> Am 06.02.23 um 16:59 schrieb Pawel Chmielewski:
> > This change enables sending BIG TCP packets on IPv6 in the ice driver using
> > generic ipv6_hopopt_jumbo_remove helper for stripping HBH header.
> >
> > Tested:
> > netperf -t TCP_RR -H 2001:db8:0:f101::1 -- -r80000,80000 -O MIN_LATENCY,P90_LATENCY,P99_LATENCY,THROUGHPUT
> >
> > Results varied from one setup to another, but in every case we got lower
> > latencies and increased transactions rate.
>
> Please give some concrete examples nevertheless.
Of course. I'll send v2 with the results. Thank you.
>
>
> Kind regards,
>
> Paul
>
>
> > Signed-off-by: Pawel Chmielewski <pawel.chmielewski@intel.com>
> > ---
> > drivers/net/ethernet/intel/ice/ice.h | 2 ++
> > drivers/net/ethernet/intel/ice/ice_main.c | 2 ++
> > drivers/net/ethernet/intel/ice/ice_txrx.c | 3 +++
> > 3 files changed, 7 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/intel/ice/ice.h b/drivers/net/ethernet/intel/ice/ice.h
> > index 3d26ff4122e0..c774fdd482cd 100644
> > --- a/drivers/net/ethernet/intel/ice/ice.h
> > +++ b/drivers/net/ethernet/intel/ice/ice.h
> > @@ -122,6 +122,8 @@
> > #define ICE_MAX_MTU (ICE_AQ_SET_MAC_FRAME_SIZE_MAX - ICE_ETH_PKT_HDR_PAD)
> > +#define ICE_MAX_TSO_SIZE 131072
> > +
> > #define ICE_UP_TABLE_TRANSLATE(val, i) \
> > (((val) << ICE_AQ_VSI_UP_TABLE_UP##i##_S) & \
> > ICE_AQ_VSI_UP_TABLE_UP##i##_M)
> > diff --git a/drivers/net/ethernet/intel/ice/ice_main.c b/drivers/net/ethernet/intel/ice/ice_main.c
> > index 22b8ad058286..8c74a48ad0d3 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_main.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_main.c
> > @@ -3421,6 +3421,8 @@ static void ice_set_netdev_features(struct net_device *netdev)
> > * be changed at runtime
> > */
> > netdev->hw_features |= NETIF_F_RXFCS;
> > +
> > + netif_set_tso_max_size(netdev, ICE_MAX_TSO_SIZE);
> > }
> > /**
> > diff --git a/drivers/net/ethernet/intel/ice/ice_txrx.c b/drivers/net/ethernet/intel/ice/ice_txrx.c
> > index ccf09c957a1c..bef927afb766 100644
> > --- a/drivers/net/ethernet/intel/ice/ice_txrx.c
> > +++ b/drivers/net/ethernet/intel/ice/ice_txrx.c
> > @@ -2297,6 +2297,9 @@ ice_xmit_frame_ring(struct sk_buff *skb, struct ice_tx_ring *tx_ring)
> > ice_trace(xmit_frame_ring, tx_ring, skb);
> > + if (unlikely(ipv6_hopopt_jumbo_remove(skb)))
> > + goto out_drop;
> > +
> > count = ice_xmit_desc_count(skb);
> > if (ice_chk_linearize(skb, count)) {
> > if (__skb_linearize(skb))
^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [Intel-wired-lan] [PATCH 1/1] ice: add support BIG TCP on IPv6
2023-02-06 15:59 [PATCH 1/1] ice: add support BIG TCP on IPv6 Pawel Chmielewski
2023-02-06 16:53 ` [Intel-wired-lan] " Paul Menzel
@ 2023-02-13 8:49 ` G, GurucharanX
1 sibling, 0 replies; 4+ messages in thread
From: G, GurucharanX @ 2023-02-13 8:49 UTC (permalink / raw)
To: Chmielewski, Pawel, netdev@vger.kernel.org; +Cc: intel-wired-lan@osuosl.org
> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of
> Pawel Chmielewski
> Sent: Monday, February 6, 2023 9:29 PM
> To: netdev@vger.kernel.org
> Cc: intel-wired-lan@osuosl.org
> Subject: [Intel-wired-lan] [PATCH 1/1] ice: add support BIG TCP on IPv6
>
> This change enables sending BIG TCP packets on IPv6 in the ice driver using
> generic ipv6_hopopt_jumbo_remove helper for stripping HBH header.
>
> Tested:
> netperf -t TCP_RR -H 2001:db8:0:f101::1 -- -r80000,80000 -O
> MIN_LATENCY,P90_LATENCY,P99_LATENCY,THROUGHPUT
>
> Results varied from one setup to another, but in every case we got lower
> latencies and increased transactions rate.
>
> Signed-off-by: Pawel Chmielewski <pawel.chmielewski@intel.com>
> ---
> drivers/net/ethernet/intel/ice/ice.h | 2 ++
> drivers/net/ethernet/intel/ice/ice_main.c | 2 ++
> drivers/net/ethernet/intel/ice/ice_txrx.c | 3 +++
> 3 files changed, 7 insertions(+)
>
Tested-by: Gurucharan G <gurucharanx.g@intel.com> (A Contingent worker at Intel)
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-02-13 8:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-06 15:59 [PATCH 1/1] ice: add support BIG TCP on IPv6 Pawel Chmielewski
2023-02-06 16:53 ` [Intel-wired-lan] " Paul Menzel
2023-02-07 16:26 ` Pawel Chmielewski
2023-02-13 8:49 ` G, GurucharanX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).