From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14CDCC05027 for ; Thu, 9 Feb 2023 07:27:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229447AbjBIH15 (ORCPT ); Thu, 9 Feb 2023 02:27:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229552AbjBIH14 (ORCPT ); Thu, 9 Feb 2023 02:27:56 -0500 Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1018E25960 for ; Wed, 8 Feb 2023 23:27:52 -0800 (PST) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 9FFAA5C00DC; Thu, 9 Feb 2023 02:27:49 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 09 Feb 2023 02:27:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1675927669; x=1676014069; bh=KkqBFMNIS8rWz0PpcdTb6h68jLgi ydKowtuoLMREmw0=; b=l6oTwWq5jBKDsIzXMYroUoXimdyxR3MJhoxt98svq5mt EU/wJK4vLWr3GoscBMdMwU3sByEdpU0m3k0DLrrYuil65tJoCvFKcGHrLL0XtD8d FCABlSxnHvObyh3bHDVAeFcl0/awz+8CjLAhUHc8iXXiugWz0O5oCnUKX+049WNh bgf81Bk+TNMfddKMQWaEwy0dZrcSKv+ID5sCsbV40ewmFdEjDG1cOhujFCLFAuCm FZ0lP+XcVrMJVDH9BTnEEY7Dod6w3IyVTvgMbbxn+kP9HJWQ0knWZVT9DHW2qEZS yWtBubc5d+JLvsGYQrnz0uKGw3HnbXEInFom+rb7RA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudehvddgheduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnhepvddufeevkeehueegfedtvdevfefgudeifeduieefgfelkeehgeelgeejjeeg gefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepih guohhstghhsehiughoshgthhdrohhrgh X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 9 Feb 2023 02:27:48 -0500 (EST) Date: Thu, 9 Feb 2023 09:27:44 +0200 From: Ido Schimmel To: Eric Dumazet Cc: "David S . Miller" , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, eric.dumazet@gmail.com, Soheil Hassas Yeganeh , Alexander Duyck , syzbot Subject: Re: [PATCH net-next] net: enable usercopy for skb_small_head_cache Message-ID: References: <20230208142508.3278406-1-edumazet@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230208142508.3278406-1-edumazet@google.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, Feb 08, 2023 at 02:25:08PM +0000, 'Eric Dumazet' via syzkaller wrote: > syzbot and other bots reported that we have to enable > user copy to/from skb->head. [1] > > We can prevent access to skb_shared_info, which is a nice > improvement over standard kmem_cache. > > Layout of these kmem_cache objects is: > > < SKB_SMALL_HEAD_HEADROOM >< struct skb_shared_info > [...] > > Fixes: bf9f1baa279f ("net: add dedicated kmem_cache for typical/small skb->head") > Reported-by: syzbot > Signed-off-by: Eric Dumazet Tested-by: Ido Schimmel Hit this one as well, patch solved the problem. Thanks!