From: asmadeus@codewreck.org
To: Zhengchao Shao <shaozhengchao@huawei.com>
Cc: Leon Romanovsky <leon@kernel.org>,
v9fs-developer@lists.sourceforge.net, netdev@vger.kernel.org,
ericvh@gmail.com, lucho@ionkov.net, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux_oss@crudebyte.com, tom@opengridcomputing.com,
weiyongjun1@huawei.com, yuehaibing@huawei.com
Subject: Re: [PATCH v2] 9p/rdma: unmap receive dma buffer in rdma_request()/post_recv()
Date: Sat, 11 Feb 2023 09:22:04 +0900 [thread overview]
Message-ID: <Y+bfrI+u98gM9a8j@codewreck.org> (raw)
In-Reply-To: <Y7UtGw6nBLFpXpPh@unreal>
Leon Romanovsky wrote on Wed, Jan 04, 2023 at 09:39:07AM +0200:
> On Wed, Jan 04, 2023 at 10:04:24AM +0800, Zhengchao Shao wrote:
> > When down_interruptible() or ib_post_send() failed in rdma_request(),
> > receive dma buffer is not unmapped. Add unmap action to error path.
> > Also if ib_post_recv() failed in post_recv(), dma buffer is not unmapped.
> > Add unmap action to error path.
> >
> > Fixes: fc79d4b104f0 ("9p: rdma: RDMA Transport Support for 9P")
> > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
Sorry for the delay -- I have no way of testing it but it looks sane,
I'll submit it when 6.3 opens up in a week or two.
Thanks for the patch & Leon for the review.
--
Dominique
prev parent reply other threads:[~2023-02-11 0:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-04 2:04 [PATCH v2] 9p/rdma: unmap receive dma buffer in rdma_request()/post_recv() Zhengchao Shao
2023-01-04 7:39 ` Leon Romanovsky
2023-02-11 0:22 ` asmadeus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+bfrI+u98gM9a8j@codewreck.org \
--to=asmadeus@codewreck.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ericvh@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux_oss@crudebyte.com \
--cc=lucho@ionkov.net \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaozhengchao@huawei.com \
--cc=tom@opengridcomputing.com \
--cc=v9fs-developer@lists.sourceforge.net \
--cc=weiyongjun1@huawei.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).