From: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
To: Xin Long <lucien.xin@gmail.com>
Cc: network dev <netdev@vger.kernel.org>,
David Ahern <dsahern@gmail.com>,
stephen@networkplumber.org, Jamal Hadi Salim <jhs@mojatatu.com>,
Cong Wang <xiyou.wangcong@gmail.com>,
Jiri Pirko <jiri@resnulli.us>,
Davide Caratti <dcaratti@redhat.com>
Subject: Re: [PATCH iproute2-next] tc: m_ct: add support for helper
Date: Fri, 10 Feb 2023 17:20:35 -0800 [thread overview]
Message-ID: <Y+btY0hReqhnviDK@t14s.localdomain> (raw)
In-Reply-To: <ab1e6bfbefff74b2b4fe230162b198c38cf5b394.1676065393.git.lucien.xin@gmail.com>
On Fri, Feb 10, 2023 at 04:43:13PM -0500, Xin Long wrote:
> This patch is to add the setup and dump for helper in tc ct action
> in userspace, and the support in kernel was added in:
>
> https://lore.kernel.org/netdev/cover.1667766782.git.lucien.xin@gmail.com/
>
> here is an example for usage:
>
> # ip link add dummy0 type dummy
> # tc qdisc add dev dummy0 ingress
>
> # tc filter add dev dummy0 ingress proto ip flower ip_proto \
> tcp ct_state -trk action ct helper ipv4-tcp-ftp
It is not wrong as is, but the example could limit it to port 21.
>
> # tc filter show dev dummy0 ingress
> filter protocol ip pref 49152 flower chain 0 handle 0x1
> eth_type ipv4
> ip_proto tcp
> ct_state -trk
> not_in_hw
> action order 1: ct zone 0 helper ipv4-tcp-ftp pipe
> index 1 ref 1 bind
>
> Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
next prev parent reply other threads:[~2023-02-11 1:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 21:43 [PATCH iproute2-next] tc: m_ct: add support for helper Xin Long
2023-02-11 1:20 ` Marcelo Ricardo Leitner [this message]
2023-02-11 17:21 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+btY0hReqhnviDK@t14s.localdomain \
--to=marcelo.leitner@gmail.com \
--cc=dcaratti@redhat.com \
--cc=dsahern@gmail.com \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=lucien.xin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox