From: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
To: Alexander Lobakin <alexandr.lobakin@intel.com>
Cc: "Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"Andrii Nakryiko" <andrii@kernel.org>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Martin KaFai Lau" <martin.lau@linux.dev>,
"Song Liu" <song@kernel.org>,
"Jesper Dangaard Brouer" <hawk@kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
bpf@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH bpf-next 0/6] ice: post-mbuf fixes
Date: Mon, 13 Feb 2023 18:57:56 +0100 [thread overview]
Message-ID: <Y+p6JAsc+OHxARyq@boxer> (raw)
In-Reply-To: <20230210170618.1973430-1-alexandr.lobakin@intel.com>
On Fri, Feb 10, 2023 at 06:06:12PM +0100, Alexander Lobakin wrote:
> The set grew from the poor performance of %BPF_F_TEST_XDP_LIVE_FRAMES
> when the ice-backed device is a sender. Initially there were around
> 3.3 Mpps / thread, while I have 5.5 on skb-based pktgen...
>
> After fixing 0005 (0004 is a prereq for it) first (strange thing nobody
> noticed that earlier), I started catching random OOMs. This is how 0002
> (and partially 0001) appeared.
> 0003 is a suggestion from Maciej to not waste time on refactoring dead
> lines. 0006 is a "cherry on top" to get away with the final 6.7 Mpps.
> 4.5 of 6 are fixes, but only the first three are tagged, since it then
> starts being tricky. I may backport them manually later on.
>
> TL;DR for the series is that shortcuts are good, but only as long as
> they don't make the driver miss important things. %XDP_TX is purely
> driver-local, however .ndo_xdp_xmit() is not, and sometimes assumptions
> can be unsafe there.
>
> With that series and also one core code patch[0], "live frames" and
> xdp-trafficgen are now safe'n'fast on ice (probably more to come).
>
> [0] https://lore.kernel.org/all/20230209172827.874728-1-alexandr.lobakin@intel.com
> ---
> Goes to directly to bpf-next as touches the recently added/changed code.
For the series:
Acked-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
>
> Alexander Lobakin (6):
> ice: fix ice_tx_ring::xdp_tx_active underflow
> ice: fix XDP Tx ring overrun
> ice: remove two impossible branches on XDP Tx cleaning
> ice: robustify cleaning/completing XDP Tx buffers
> ice: fix freeing XDP frames backed by Page Pool
> ice: micro-optimize .ndo_xdp_xmit() path
>
> drivers/net/ethernet/intel/ice/ice_txrx.c | 67 +++++++++-----
> drivers/net/ethernet/intel/ice/ice_txrx.h | 37 ++++++--
> drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 88 ++++++++++++-------
> drivers/net/ethernet/intel/ice/ice_txrx_lib.h | 4 +-
> drivers/net/ethernet/intel/ice/ice_xsk.c | 12 +--
> 5 files changed, 136 insertions(+), 72 deletions(-)
>
> --
> 2.39.1
>
next prev parent reply other threads:[~2023-02-13 17:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-10 17:06 [PATCH bpf-next 0/6] ice: post-mbuf fixes Alexander Lobakin
2023-02-10 17:06 ` [PATCH bpf-next 1/6] ice: fix ice_tx_ring::xdp_tx_active underflow Alexander Lobakin
2023-02-10 17:06 ` [PATCH bpf-next 2/6] ice: fix XDP Tx ring overrun Alexander Lobakin
2023-02-10 17:06 ` [PATCH bpf-next 3/6] ice: remove two impossible branches on XDP Tx cleaning Alexander Lobakin
2023-02-10 17:06 ` [PATCH bpf-next 4/6] ice: robustify cleaning/completing XDP Tx buffers Alexander Lobakin
2023-02-10 17:06 ` [PATCH bpf-next 5/6] ice: fix freeing XDP frames backed by Page Pool Alexander Lobakin
2023-02-10 17:06 ` [PATCH bpf-next 6/6] ice: micro-optimize .ndo_xdp_xmit() path Alexander Lobakin
2023-02-10 18:09 ` [PATCH bpf-next 0/6] ice: post-mbuf fixes Toke Høiland-Jørgensen
2023-02-13 14:53 ` Alexander Lobakin
2023-02-13 17:57 ` Maciej Fijalkowski [this message]
2023-02-13 18:21 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+p6JAsc+OHxARyq@boxer \
--to=maciej.fijalkowski@intel.com \
--cc=alexandr.lobakin@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hawk@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=magnus.karlsson@intel.com \
--cc=martin.lau@linux.dev \
--cc=netdev@vger.kernel.org \
--cc=song@kernel.org \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).