Netdev List
 help / color / mirror / Atom feed
From: Hangbin Liu <liuhangbin@gmail.com>
To: Matthieu Baerts <matthieu.baerts@tessares.net>
Cc: netdev@vger.kernel.org, Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Andrii Nakryiko <andrii@kernel.org>,
	bpf@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	"David S . Miller" <davem@davemloft.net>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
	John Fastabend <john.fastabend@gmail.com>,
	KP Singh <kpsingh@kernel.org>,
	Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
	Jiri Olsa <jolsa@kernel.org>, Mykola Lysenko <mykolal@fb.com>,
	Felix Maurer <fmaurer@redhat.com>,
	Davide Caratti <dcaratti@redhat.com>
Subject: Re: [PATCH bpf] selftests/bpf: enable mptcp before testing
Date: Tue, 14 Feb 2023 11:11:45 +0800	[thread overview]
Message-ID: <Y+r78ZUqIsvaWjQG@Laptop-X1> (raw)
In-Reply-To: <19a6a29d-85f3-b8d7-c9d9-3c97a625bd13@tessares.net>

On Mon, Feb 13, 2023 at 05:28:19PM +0100, Matthieu Baerts wrote:
> But again, I'm not totally against that, I'm just saying that if these
> tests are executed in dedicated netns, this modification is not needed
> when using a vanilla kernel ;-)
> 
> Except if I misunderstood and these tests are not executed in dedicated
> netns?

I tried on my test machine, it looks the test is executed in init netns.
I modified my patch by setting the net.mptcp.enabled to 1 without setting
it back. You can find the value is changed after testing.

# cat /proc/sys/net/mptcp/enabled
0
# ./test_progs -t mptcp
#127/1   mptcp/base:OK
#127     mptcp:OK
Summary: 1/1 PASSED, 0 SKIPPED, 0 FAILED
# cat /proc/sys/net/mptcp/enabled
1

Thanks
Hangbin

  reply	other threads:[~2023-02-14  3:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-10  9:32 [PATCH bpf] selftests/bpf: enable mptcp before testing Hangbin Liu
2023-02-10 16:22 ` Matthieu Baerts
2023-02-13  4:10   ` Hangbin Liu
2023-02-13 16:28     ` Matthieu Baerts
2023-02-14  3:11       ` Hangbin Liu [this message]
2023-02-14 19:22         ` Martin KaFai Lau
2023-02-15  3:43           ` Hangbin Liu
2023-02-15  9:58             ` Matthieu Baerts
2023-02-16  8:13               ` Hangbin Liu
2023-02-17  7:04                 ` Martin KaFai Lau
2023-02-17  7:35                   ` Hangbin Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y+r78ZUqIsvaWjQG@Laptop-X1 \
    --to=liuhangbin@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=dcaratti@redhat.com \
    --cc=fmaurer@redhat.com \
    --cc=haoluo@google.com \
    --cc=john.fastabend@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kpsingh@kernel.org \
    --cc=kuba@kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=matthieu.baerts@tessares.net \
    --cc=mykolal@fb.com \
    --cc=netdev@vger.kernel.org \
    --cc=sdf@google.com \
    --cc=song@kernel.org \
    --cc=yhs@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox