From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5CDF4C61DA4 for ; Tue, 14 Feb 2023 16:23:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229635AbjBNQXJ (ORCPT ); Tue, 14 Feb 2023 11:23:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38406 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229604AbjBNQXH (ORCPT ); Tue, 14 Feb 2023 11:23:07 -0500 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DFF2B93C3 for ; Tue, 14 Feb 2023 08:23:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=eEHiBC/5+Ij9Pp02K/xqZsa9khaDCAoavMTyLu+00cg=; b=TRdD84bdpwVAlLTi874t0bXadD PyERA/ovGeC6MY6ezGlYRenS8+TSsmt+QfD4/D8u2CFqbMnfCit/RPGg8DZjofxGiTr2amolxAqZ3 9RADjrcc7v2IkWDY1DmT4KdVY+DLAWX38ua4TqELtw8u+JOyGzbTag+LJraC72uLpwKw=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1pRy58-004yK7-Gx; Tue, 14 Feb 2023 17:23:02 +0100 Date: Tue, 14 Feb 2023 17:23:02 +0100 From: Andrew Lunn To: Mengyuan Lou Cc: netdev@vger.kernel.org, jiawenwu@trustnetic.com Subject: Re: [PATCH net-next v3] net: wangxun: Add the basic ethtool interfaces Message-ID: References: <20230214091527.69943-1-mengyuanlou@net-swift.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230214091527.69943-1-mengyuanlou@net-swift.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 14, 2023 at 05:15:27PM +0800, Mengyuan Lou wrote: > Add the basic ethtool ops get_drvinfo and get_link for ngbe and txgbe. > Ngbe implements get_link_ksettings, nway_reset and set_link_ksettings > for free using phylib code. > The code related to the physical interface is not yet fully implemented > in txgbe using phylink code. So do not implement get_link_ksettings, > nway_reset and set_link_ksettings in txgbe. > > Signed-off-by: Mengyuan Lou Reviewed-by: Andrew Lunn Andrew