From: Marc Bornand <dev.mbornand@systemb.ch>
To: Denis Kirjanov <dkirjanov@suse.de>
Cc: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Kalle Valo <kvalo@kernel.org>, Yohan Prod'homme <kernel@zoddo.fr>,
stable@vger.kernel.org
Subject: Re: [PATCH v4] Set ssid when authenticating
Date: Tue, 14 Feb 2023 22:01:35 +0000 [thread overview]
Message-ID: <Y+wEtf2dy8hXWYA4@opmb2> (raw)
In-Reply-To: <13e8e0bb-b2a2-e138-75c0-54e61a5d679e@suse.de>
On Tue, Feb 14, 2023 at 04:27:27PM +0300, Denis Kirjanov wrote:
>
>
> On 2/14/23 16:20, Marc Bornand wrote:
> > changes since v3:
> > - add missing NULL check
> > - add missing break
> >
> > changes since v2:
> > - The code was tottaly rewritten based on the disscution of the
> > v2 patch.
> > - the ssid is set in __cfg80211_connect_result() and only if the ssid is
> > not already set.
> > - Do not add an other ssid reset path since it is already done in
> > __cfg80211_disconnected()
> >
> > When a connexion was established without going through
> > NL80211_CMD_CONNECT, the ssid was never set in the wireless_dev struct.
> > Now we set it in __cfg80211_connect_result() when it is not already set.
>
> A couple of small nits
>
> >
> > Reported-by: Yohan Prod'homme <kernel@zoddo.fr>
> > Fixes: 7b0a0e3c3a88260b6fcb017e49f198463aa62ed1
> Please add a test description to the fixes tag
What do you mean by "test description" ?
Marc
next prev parent reply other threads:[~2023-02-14 22:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 13:20 [PATCH v4] Set ssid when authenticating Marc Bornand
2023-02-14 13:27 ` Denis Kirjanov
2023-02-14 22:01 ` Marc Bornand [this message]
2023-02-14 22:04 ` Conor Dooley
2023-02-15 5:35 ` Kalle Valo
2023-02-15 8:12 ` Marc Bornand
2023-02-15 8:32 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+wEtf2dy8hXWYA4@opmb2 \
--to=dev.mbornand@systemb.ch \
--cc=davem@davemloft.net \
--cc=dkirjanov@suse.de \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=kernel@zoddo.fr \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).