Re: [PATCH net 3/4] net: hinic: fix the issue of CMDQ memory leaks

[Leon Romanovsky <leon@kernel.org>]

On Wed, Oct 19, 2022 at 05:37:42PM +0800, shaozhengchao wrote:
> 
> 
> On 2022/10/19 16:39, Leon Romanovsky wrote:
> > On Wed, Oct 19, 2022 at 03:41:06PM +0800, shaozhengchao wrote:
> > > 
> > > 
> > > On 2022/10/19 15:20, Leon Romanovsky wrote:
> > > > On Wed, Oct 19, 2022 at 10:42:19AM +0800, Zhengchao Shao wrote:
> > > > > When hinic_set_cmdq_depth() fails in hinic_init_cmdqs(), the cmdq memory is
> > > > > not released correctly. Fix it.
> > > > > 
> > > > > Fixes: 72ef908bb3ff ("hinic: add three net_device_ops of vf")
> > > > > Signed-off-by: Zhengchao Shao <shaozhengchao@huawei.com>
> > > > > ---
> > > > >    drivers/net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 5 +++++
> > > > >    1 file changed, 5 insertions(+)
> > > > 
> > > > <...>
> > > > 
> > > > > +	cmdq_type = HINIC_CMDQ_SYNC;
> > > > > +	for (; cmdq_type < HINIC_MAX_CMDQ_TYPES; cmdq_type++)
> > > > 
> > > > Why do you have this "for loops" in all places? There is only one cmdq_type.
> > > > 
> > > > Thanks
> > > Hi Leon:
> > > 	Thank you for your review. Now, only the synchronous CMDQ is
> > > enabled for the current CMDQs. New type of CMDQ could be added later.
> > 
> > Single command type was added in 2017, and five years later, new type wasn't added yet.
> > 
> OK, I will modify in V2, and I will do cleanup in another patch.

Thanks

> 
> Thanks
> 
> Zhengchao Shao
> 
> > > So looping style is maintained on both the allocation and release paths.
> > > 
> > > Zhengchao Shao