From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7AC3DC433FE for ; Thu, 13 Oct 2022 06:56:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229783AbiJMG42 (ORCPT ); Thu, 13 Oct 2022 02:56:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37386 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229748AbiJMG40 (ORCPT ); Thu, 13 Oct 2022 02:56:26 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EAE3A1162DC for ; Wed, 12 Oct 2022 23:56:23 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id s2so1327687edd.2 for ; Wed, 12 Oct 2022 23:56:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20210112.gappssmtp.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=hTQYscxea5kpG4IJ5jBXCinWCVMiCrKi+HoK6IiLIuE=; b=lyTp+EXHucXB3gaWPjRGYXQMejZgFKzdyuXcwUHwK/NMFQkvEIz2T+8sR8gQxuRPOc pCcbhL+BK56Sv8Z/mrBdBG/jjzxHl6k2Tn4GKGItpIccU1nQwLk68dTQ88eqUIRfC4M5 sjk7kUMFUXpmoL8DD6VVWPPaXhHN0Ou3WfghHmfYowrypXhWs5nvAFvZtRcHSaMk7OMt IgbgI/LpU7PHxryNxPK7mCYYW3JUT0HA/iRl8n5Vfu2A9fleTXXYD1lj5geUvdpVxYXz jGtI8VOO+AwICr7D7sCm3qDrxVt5nmOYhbKYLjodACCc5SCGDiQTAqTlF4N+tA5LZKkV qAdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=hTQYscxea5kpG4IJ5jBXCinWCVMiCrKi+HoK6IiLIuE=; b=kiCCJI2Vayhl3ccDK3Ry8nkpmjAKoU/7tgiuH/COgjXswjx+N/X3hMpeMQsIoSyPu1 f/UGk/G/71talx59kkzu2AEmP0F7uzkJWelt9ClwxStp8RXBXt62yB2P+Bm55bHoK3AT LOrSWXAnwg7kAOUHQAW83rKV6GOQuT4zAiEkMrtE1Er6skmvjGnAf8OnLkSHHzkf4Ok7 aRSdr/VrHwVnNS7PQUl3uaYVnCufC4wsngHY9wNDBqvQZmZsLQAZnxEzP09js27lj+TF Unb/9YzEIHkQs6sDXqn70n4a31C+mDdrxNDddvk2QC2oQbPvwOEPU/Q+bO6b5auq6WUO NUjQ== X-Gm-Message-State: ACrzQf3uiPNUdpF8eY9Ws3HMiQYdH2NO4sd2a3KNfRg5Qm+O2Ac08G+r fDCsIJCebz0+mAg2ToAvOAXPCdoKISmTOQaZ X-Google-Smtp-Source: AMsMyM4WS/KUJ98zs7jglOqWm2qitHwvXXYr6c0kUOoIpkYdD262tltvqeI0sJmiYyPjtYLM/dWnvw== X-Received: by 2002:a05:6402:1e8e:b0:45c:af84:63dd with SMTP id f14-20020a0564021e8e00b0045caf8463ddmr6086445edf.190.1665644181835; Wed, 12 Oct 2022 23:56:21 -0700 (PDT) Received: from localhost ([86.61.181.4]) by smtp.gmail.com with ESMTPSA id gc35-20020a1709072b2300b0073dc5bb7c32sm2436288ejc.64.2022.10.12.23.56.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Oct 2022 23:56:21 -0700 (PDT) Date: Thu, 13 Oct 2022 08:56:20 +0200 From: Jiri Pirko To: Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, Vadim Fedorenko Subject: Re: [RFC PATCH v3 1/6] dpll: Add DPLL framework base functions Message-ID: References: <20221010011804.23716-1-vfedorenko@novek.ru> <20221010011804.23716-2-vfedorenko@novek.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Wed, Oct 12, 2022 at 10:15:23PM CEST, vfedorenko@novek.ru wrote: >On 12.10.2022 11:47, Jiri Pirko wrote: >> Mon, Oct 10, 2022 at 03:17:59AM CEST, vfedorenko@novek.ru wrote: >> > From: Vadim Fedorenko >> > >> > DPLL framework is used to represent and configure DPLL devices >> > in systems. Each device that has DPLL and can configure sources >> > and outputs can use this framework. >> > >> > Signed-off-by: Vadim Fedorenko >> > Co-developed-by: Jakub Kicinski >> > Co-developed-by: Arkadiusz Kubalewski >> >> >> [...] >> >> >> > +struct dpll_device *dpll_device_alloc(struct dpll_device_ops *ops, const char *name, >> > + int sources_count, int outputs_count, void *priv) >> >> Having constant array of "pins" would not work for SyncE. For example in >> mlxsw driver, netdevs can appear and disappear within the device >> lifetime (for example port splits, linecard provision). We need to >> register/unregister pins dynamically. >> >Yes, I agree, and we are working to implement pin object with dynamic >attach/detach or reg/unreg functions. Awesome. Looking forward to the next patchset version!