From: Sabrina Dubroca <sd@queasysnail.net>
To: Leon Romanovsky <leon@kernel.org>
Cc: netdev@vger.kernel.org, Antoine Tenart <atenart@kernel.org>
Subject: Re: [PATCH net 3/5] macsec: fix secy->n_rx_sc accounting
Date: Fri, 14 Oct 2022 09:43:41 +0200 [thread overview]
Message-ID: <Y0kTLaz95PUE4uQz@hog> (raw)
In-Reply-To: <Y0j+2J2uBqrhqRtg@unreal>
2022-10-14, 09:16:56 +0300, Leon Romanovsky wrote:
[...]
> > @@ -1897,15 +1899,16 @@ static int macsec_add_rxsc(struct sk_buff *skb, struct genl_info *info)
> > secy = &macsec_priv(dev)->secy;
> > sci = nla_get_sci(tb_rxsc[MACSEC_RXSC_ATTR_SCI]);
> >
> > - rx_sc = create_rx_sc(dev, sci);
> > +
> > + if (tb_rxsc[MACSEC_RXSC_ATTR_ACTIVE])
> > + active = !!nla_get_u8(tb_rxsc[MACSEC_RXSC_ATTR_ACTIVE]);
>
> You don't need !! to assign to bool variables and can safely omit them.
Yeah, but I'm just moving existing code, see below.
(please trim your replies, nobody wants to scroll through endless
quoting just to find one comment hiding in the middle)
>
> thanks
>
> > +
> > + rx_sc = create_rx_sc(dev, sci, active);
> > if (IS_ERR(rx_sc)) {
> > rtnl_unlock();
> > return PTR_ERR(rx_sc);
> > }
> >
> > - if (tb_rxsc[MACSEC_RXSC_ATTR_ACTIVE])
> > - rx_sc->active = !!nla_get_u8(tb_rxsc[MACSEC_RXSC_ATTR_ACTIVE]);
--
Sabrina
next prev parent reply other threads:[~2022-10-14 7:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 14:15 [PATCH net 0/5] macsec: offload-related fixes Sabrina Dubroca
2022-10-13 14:15 ` [PATCH net 1/5] Revert "net: macsec: report real_dev features when HW offloading is enabled" Sabrina Dubroca
2022-10-13 14:15 ` [PATCH net 2/5] macsec: delete new rxsc when offload fails Sabrina Dubroca
2022-10-13 14:15 ` [PATCH net 3/5] macsec: fix secy->n_rx_sc accounting Sabrina Dubroca
2022-10-14 6:16 ` Leon Romanovsky
2022-10-14 7:43 ` Sabrina Dubroca [this message]
2022-10-14 11:08 ` Leon Romanovsky
2022-10-13 14:15 ` [PATCH net 4/5] macsec: fix detection of RXSCs when toggling offloading Sabrina Dubroca
2022-10-13 14:15 ` [PATCH net 5/5] macsec: clear encryption keys from the stack after setting up offload Sabrina Dubroca
2022-10-14 6:13 ` [PATCH net 0/5] macsec: offload-related fixes Leon Romanovsky
2022-10-14 7:43 ` Sabrina Dubroca
2022-10-14 11:03 ` Leon Romanovsky
2022-10-14 14:03 ` Antoine Tenart
2022-10-18 6:28 ` Leon Romanovsky
2022-10-20 13:54 ` Sabrina Dubroca
2022-10-23 7:52 ` Leon Romanovsky
2022-10-24 8:24 ` Sabrina Dubroca
2022-10-24 8:43 ` Leon Romanovsky
2022-10-24 22:05 ` Sabrina Dubroca
2022-10-25 6:55 ` Leon Romanovsky
2022-10-14 14:44 ` Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y0kTLaz95PUE4uQz@hog \
--to=sd@queasysnail.net \
--cc=atenart@kernel.org \
--cc=leon@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).