From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 691B1C433FE for ; Fri, 14 Oct 2022 07:44:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229485AbiJNHoT convert rfc822-to-8bit (ORCPT ); Fri, 14 Oct 2022 03:44:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42132 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229658AbiJNHoR (ORCPT ); Fri, 14 Oct 2022 03:44:17 -0400 Received: from us-smtp-delivery-44.mimecast.com (us-smtp-delivery-44.mimecast.com [207.211.30.44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EECB98E0FC for ; Fri, 14 Oct 2022 00:44:15 -0700 (PDT) Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-183-QuuEX9mSOKGvI1-MOBNjKg-1; Fri, 14 Oct 2022 03:44:11 -0400 X-MC-Unique: QuuEX9mSOKGvI1-MOBNjKg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 586A58027EC; Fri, 14 Oct 2022 07:44:11 +0000 (UTC) Received: from hog (unknown [10.39.192.237]) by smtp.corp.redhat.com (Postfix) with ESMTPS id EC9BC1402140; Fri, 14 Oct 2022 07:44:09 +0000 (UTC) Date: Fri, 14 Oct 2022 09:43:45 +0200 From: Sabrina Dubroca To: Leon Romanovsky Cc: netdev@vger.kernel.org, Antoine Tenart , Mark Starovoytov , Igor Russkikh Subject: Re: [PATCH net 0/5] macsec: offload-related fixes Message-ID: References: MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: queasysnail.net Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org 2022-10-14, 09:13:39 +0300, Leon Romanovsky wrote: > On Thu, Oct 13, 2022 at 04:15:38PM +0200, Sabrina Dubroca wrote: > > I'm working on a dummy offload for macsec on netdevsim. It just has a > > small SecY and RXSC table so I can trigger failures easily on the > > ndo_* side. It has exposed a couple of issues. > > > > The first patch will cause some performance degradation, but in the > > current state it's not possible to offload macsec to lower devices > > that also support ipsec offload. > > Please don't, IPsec offload is available and undergoing review. > https://lore.kernel.org/netdev/cover.1662295929.git.leonro@nvidia.com/ > > This is whole series (XFRM + driver) for IPsec full offload. > https://git.kernel.org/pub/scm/linux/kernel/git/leon/linux-rdma.git/log/?h=xfrm-next Yes, and that's not upstream yet. That patchset is also doing nothing to address the issue I'm refering to here, where xfrm_api_check rejects the macsec device because it has the NETIF_F_HW_ESP flag (passed from the lower device) and no xfrmdev_ops. OTOH the mlx5 driver has both macsec and ipsec offload already, so I think it should be affected by this exact issue. There are other feature flags that almost certainly shouldn't be copied from the lower device, such as the TLS offload flags. -- Sabrina