* [PATCH net] net: dsa: uninitialized variable in dsa_slave_netdevice_event()
@ 2022-10-14 15:08 Dan Carpenter
2022-10-15 10:20 ` patchwork-bot+netdevbpf
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2022-10-14 15:08 UTC (permalink / raw)
To: Andrew Lunn, Vladimir Oltean
Cc: Vivien Didelot, Florian Fainelli, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, netdev, kernel-janitors
Return zero if both dsa_slave_dev_check() and netdev_uses_dsa() are false.
Fixes: acc43b7bf52a ("net: dsa: allow masters to join a LAG")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
(Vladimir helped me with this patch)
net/dsa/slave.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/dsa/slave.c b/net/dsa/slave.c
index 1a59918d3b30..a9fde48cffd4 100644
--- a/net/dsa/slave.c
+++ b/net/dsa/slave.c
@@ -3145,7 +3145,7 @@ static int dsa_slave_netdevice_event(struct notifier_block *nb,
case NETDEV_CHANGELOWERSTATE: {
struct netdev_notifier_changelowerstate_info *info = ptr;
struct dsa_port *dp;
- int err;
+ int err = 0;
if (dsa_slave_dev_check(dev)) {
dp = dsa_slave_to_port(dev);
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH net] net: dsa: uninitialized variable in dsa_slave_netdevice_event()
2022-10-14 15:08 [PATCH net] net: dsa: uninitialized variable in dsa_slave_netdevice_event() Dan Carpenter
@ 2022-10-15 10:20 ` patchwork-bot+netdevbpf
0 siblings, 0 replies; 2+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-10-15 10:20 UTC (permalink / raw)
To: Dan Carpenter
Cc: andrew, olteanv, vivien.didelot, f.fainelli, davem, edumazet,
kuba, pabeni, netdev, kernel-janitors
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Fri, 14 Oct 2022 18:08:39 +0300 you wrote:
> Return zero if both dsa_slave_dev_check() and netdev_uses_dsa() are false.
>
> Fixes: acc43b7bf52a ("net: dsa: allow masters to join a LAG")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> (Vladimir helped me with this patch)
>
> [...]
Here is the summary with links:
- [net] net: dsa: uninitialized variable in dsa_slave_netdevice_event()
https://git.kernel.org/netdev/net/c/0a6d58a70a39
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-15 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-10-14 15:08 [PATCH net] net: dsa: uninitialized variable in dsa_slave_netdevice_event() Dan Carpenter
2022-10-15 10:20 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).