From: Leon Romanovsky <leon@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, richardcochran@gmail.com
Subject: Re: [PATCH net] MAINTAINERS: add keyword match on PTP
Date: Thu, 20 Oct 2022 09:12:20 +0300 [thread overview]
Message-ID: <Y1DmxBUCOYpWn5GY@unreal> (raw)
In-Reply-To: <Y1Dh8kFNicjxzNHn@unreal>
On Thu, Oct 20, 2022 at 08:51:46AM +0300, Leon Romanovsky wrote:
> On Wed, Oct 19, 2022 at 07:19:13PM -0700, Jakub Kicinski wrote:
> > Most of PTP drivers live under ethernet and we have to keep
> > telling people to CC the PTP maintainers. Let's try a keyword
> > match, we can refine as we go if it causes false positives.
> >
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> > ---
> > MAINTAINERS | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 5c6ce094e55e..ba8ed738494f 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -16673,6 +16673,7 @@ F: Documentation/driver-api/ptp.rst
> > F: drivers/net/phy/dp83640*
> > F: drivers/ptp/*
> > F: include/linux/ptp_cl*
> > +K: (?:\b|_)ptp(?:\b|_)
>
> I tried it with grep (maybe it is wrong) and it finds only files with
> underscores.
>
> ➜ kernel git:(m/xfrm-latest) tree | grep -E "(?:\b|_)ptp(?:\b|_)"
> │ │ │ │ │ ├── ice_ptp_consts.h
> │ │ │ │ │ ├── ice_ptp_hw.c
> │ │ │ │ │ ├── ice_ptp_hw.h
>
> And this is as it is written in MAINTAINERS without "_".
>
> ➜ kernel git:(m/xfrm-latest) tree | grep -E "\bptp\b"
> │ │ ├── sysfs-ptp
> │ │ │ │ ├── intel,ixp46x-ptp-timer.yaml
> │ │ │ ├── ptp
> │ │ │ │ ├── brcm,ptp-dte.txt
> │ │ │ │ ├── ptp-idt82p33.yaml
> │ │ │ │ ├── ptp-idtcm.yaml
> │ │ │ │ ├── ptp-ines.txt
> │ │ │ │ ├── ptp-qoriq.txt
> │ │ ├── ptp.rst
> │ │ │ │ ├── ptp.c
> │ │ │ │ ├── ptp.h
> │ │ │ │ └── xgbe-ptp.c
> │ │ │ │ │ ├── dpaa2-ptp.c
> │ │ │ │ │ ├── dpaa2-ptp.h
> │ │ │ │ │ ├── ptp.c
> │ │ │ │ │ │ ├── ptp.c
> │ │ │ │ │ │ ├── ptp.h
> │ │ │ │ │ │ ├── ptp.c
> │ │ │ │ │ │ ├── ptp.h
> │ │ │ │ ├── ptp.c
> │ │ │ │ ├── ptp.h
> │ │ │ │ │ ├── ptp.c
> │ │ │ │ │ ├── ptp.h
> │ │ │ ├── bcm-phy-ptp.c
>
> Should I try it differently?
And maybe "K: ptp" will be even better.
>
> Thanks
>
> >
> > PTP VIRTUAL CLOCK SUPPORT
> > M: Yangbo Lu <yangbo.lu@nxp.com>
> > --
> > 2.37.3
> >
next prev parent reply other threads:[~2022-10-20 6:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 2:19 [PATCH net] MAINTAINERS: add keyword match on PTP Jakub Kicinski
2022-10-20 3:15 ` Richard Cochran
2022-10-20 5:51 ` Leon Romanovsky
2022-10-20 6:12 ` Leon Romanovsky [this message]
2022-10-20 17:56 ` Jakub Kicinski
2022-10-23 8:08 ` Leon Romanovsky
2022-10-21 12:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1DmxBUCOYpWn5GY@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).