Re: [PATCH net] net: wwan: iosm: Fix 7360 WWAN card control channel mapping

Shane Parslow
2022-09-26T20:51:39Z

On Mon, 26 Sep 2022 13:11:09 -0700 Jakub Kicinski wrote:
> On Sun, 25 Sep 2022 21:05:24 -0700 Shane Parslow wrote:
>> This patch fixes the control channel mapping for the 7360, which was
>> previously the same as the 7560.
>>
>> As shown by the reverse engineering efforts of James Wah [1], the layout
>> of channels on the 7360 is actually somewhat different from that of the
>> 7560.
>>
>> A new ipc_chnl_cfg is added specifically for the 7360. The new config
>> updates channel 7 to be an AT port and removes the mbim interface, as
>> it does not exist on the 7360. The config is otherwise left the same as
>> the 7560. ipc_chnl_cfg_get is updated to switch between the two configs.
>> In ipc_imem, a special case for the mbim port is removed as it no longer
>> exists in the 7360 ipc_chnl_cfg.
>>
>> As a result of this, the second userspace AT port now functions whereas
>> previously it was routed to the trace channel. Modem crashes ("confused
>> phase", "msg timeout", "PORT open refused") resulting from garbage being
>> sent to the modem are also fixed.
>
> What's the Fixes: tag for this one?

There isn't currently an open bug report for this. I can open one if that
is preferred.
The gist is that previously, any writes to the 2nd userspace AT port
would crash the modem.
This is my first patch -- I apologize if I did things out of order.

On Mon, Sep 26, 2022 at 1:11 PM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Sun, 25 Sep 2022 21:05:24 -0700 Shane Parslow wrote:
> > This patch fixes the control channel mapping for the 7360, which was
> > previously the same as the 7560.
> >
> > As shown by the reverse engineering efforts of James Wah [1], the layout
> > of channels on the 7360 is actually somewhat different from that of the
> > 7560.
> >
> > A new ipc_chnl_cfg is added specifically for the 7360. The new config
> > updates channel 7 to be an AT port and removes the mbim interface, as
> > it does not exist on the 7360. The config is otherwise left the same as
> > the 7560. ipc_chnl_cfg_get is updated to switch between the two configs.
> > In ipc_imem, a special case for the mbim port is removed as it no longer
> > exists in the 7360 ipc_chnl_cfg.
> >
> > As a result of this, the second userspace AT port now functions whereas
> > previously it was routed to the trace channel. Modem crashes ("confused
> > phase", "msg timeout", "PORT open refused") resulting from garbage being
> > sent to the modem are also fixed.
>
> What's the Fixes: tag for this one?