From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C06B4C4332F for ; Fri, 21 Oct 2022 07:24:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229763AbiJUHYb (ORCPT ); Fri, 21 Oct 2022 03:24:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229948AbiJUHY3 (ORCPT ); Fri, 21 Oct 2022 03:24:29 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CDF86BF79; Fri, 21 Oct 2022 00:24:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3QJldfimGMGhCUVfS4T2fQs9aVrQkUBT9b7wxuInmVs=; b=ZTILIayE9X7wdaGqo8oZBO6jEI kFjfze0pHhiT162fcjz9zR0xhMJ5vcnIrncJcnVcB4ahsQ6sXSXUmk6shy20vj3tx89/uKqfrH5GX BBbMyV3A0SwzM+6Mj8+53QROktOQLRY1QD99ecZmOIt7x/ovkwEs6zLXR084uOfH93qghfLYVQOBN e4gHzybzRtjgNAUIEVYYaMgmJ9wqSR0QyeF2+yWYawQ0S8Ae/6h0ocAHRtQgg/26xYQv9pSOsU4cw 2r1XQ3X9ZB6AkBeG8KC17SX+27NsTkgUQGsznB6cl/zJVqUsDiFTfkP4n4c2zqB9cReJRQ2QoXAJQ kSdWR6Ow==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34848) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1olmNz-0008Ix-Po; Fri, 21 Oct 2022 08:24:07 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1olmNu-0003yS-L9; Fri, 21 Oct 2022 08:24:02 +0100 Date: Fri, 21 Oct 2022 08:24:02 +0100 From: "Russell King (Oracle)" To: Frank Wunderlich Cc: Frank Wunderlich , linux-mediatek@lists.infradead.org, Alexander Couzens , Felix Fietkau , John Crispin , Sean Wang , Mark Lee , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Matthias Brugger , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: mtk_sgmii: implement mtk_pcs_ops Message-ID: References: <20221020144431.126124-1-linux@fw-web.de> <02A54E45-2084-440A-A643-772C0CC9F988@public-files.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <02A54E45-2084-440A-A643-772C0CC9F988@public-files.de> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Oct 21, 2022 at 08:04:51AM +0200, Frank Wunderlich wrote: > On my board (bpi-r3) we have no autoneg on the gmacs. We have a switch (mt7531) with fixed-link on the first and a sfp-cage on the other. Second mac gets speed-setting (1000base-X or 2500base-X) from sfp eeprom, but no advertisement from the "other end". Imho it is always full duplex. If it's a fixed link, then this function you're adding won't be called. It's only called for in-band mode which is exclusive with fixed-link mode. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!