From: Petr Mladek <pmladek@suse.com>
To: John Ogness <john.ogness@linutronix.de>
Cc: Sergey Senozhatsky <senozhatsky@chromium.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH printk v2 09/38] netconsole: use console_is_enabled()
Date: Fri, 21 Oct 2022 15:14:59 +0200 [thread overview]
Message-ID: <Y1KbU2r09bEm2rHX@alley> (raw)
In-Reply-To: <20221019145600.1282823-10-john.ogness@linutronix.de>
On Wed 2022-10-19 17:01:31, John Ogness wrote:
> Replace (console->flags & CON_ENABLED) usage with console_is_enabled().
>
> Signed-off-by: John Ogness <john.ogness@linutronix.de>
The change is straightforward:
Reviewed-by: Petr Mladek <pmladek@suse.com>
The comment below is just a lamentation about the netconsole code.
> ---
> drivers/net/netconsole.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/netconsole.c b/drivers/net/netconsole.c
> index bdff9ac5056d..073e59a06f21 100644
> --- a/drivers/net/netconsole.c
> +++ b/drivers/net/netconsole.c
> @@ -332,7 +332,7 @@ static ssize_t enabled_store(struct config_item *item,
> }
>
> if (enabled) { /* true */
> - if (nt->extended && !(netconsole_ext.flags & CON_ENABLED)) {
> + if (nt->extended && !console_is_enabled(&netconsole_ext)) {
> netconsole_ext.flags |= CON_ENABLED;
> register_console(&netconsole_ext);
> }
> @@ -915,7 +915,7 @@ static int __init init_netconsole(void)
> if (err)
> goto undonotifier;
>
> - if (netconsole_ext.flags & CON_ENABLED)
> + if (console_is_enabled(&netconsole_ext))
> register_console(&netconsole_ext);
> register_console(&netconsole);
> pr_info("network logging started\n");
Just for record:
This looks like a (mis)use of CON_ENABLED flag. It took me some time
to understand why pre-enabled consoles are handled special way in
register_console(). I partly documented it in
try_enable_preferred_console():
/*
* Some consoles, such as pstore and netconsole, can be enabled even
* without matching. Accept the pre-enabled consoles only when match()
* and setup() had a chance to be called.
*/
if (console_is_enabled(newcon) && (c->user_specified == user_specified))
return 0;
In my bottom driver, I have a patch cleaning this. It is part of a bigger
clean up that is not ready for upstream :-/
Best Regards,
Petr
next prev parent reply other threads:[~2022-10-21 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 14:55 [PATCH printk v2 00/38] reduce console_lock scope John Ogness
2022-10-19 14:55 ` [PATCH printk v2 09/38] netconsole: use console_is_enabled() John Ogness
2022-10-21 13:14 ` Petr Mladek [this message]
2022-11-04 15:12 ` John Ogness
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1KbU2r09bEm2rHX@alley \
--to=pmladek@suse.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john.ogness@linutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rostedt@goodmis.org \
--cc=senozhatsky@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox