From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14AF8C04A95 for ; Sat, 22 Oct 2022 13:53:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229576AbiJVNxf (ORCPT ); Sat, 22 Oct 2022 09:53:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55794 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbiJVNxe (ORCPT ); Sat, 22 Oct 2022 09:53:34 -0400 Received: from wout3-smtp.messagingengine.com (wout3-smtp.messagingengine.com [64.147.123.19]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 226AE27CFD8 for ; Sat, 22 Oct 2022 06:53:34 -0700 (PDT) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 7AB8D32006F2; Sat, 22 Oct 2022 09:53:30 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 22 Oct 2022 09:53:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1666446810; x=1666533210; bh=KcKyZit+XwaY6TxbOToGCYKAxbe8 8cDjRSehsyijV6U=; b=J3Ymo3HawONpngRpCEPMP2XmhrdBtcLx0sUU+XfBbd9g FsFdOtE1+6NLsYCfld4vjUKSnnpQ1tux8ih4gR1B9/54TAdNPMu6AUYFR7fsKaJv I6lc6fhg9aiStOmm3mSgj7t7iXfWY2DhPvmd+/9wnlg/zUF4zBo2MMYE3Fxskcaf 327wi1hMYrhCK6amvWgZ8RlsgGvWpB4BUPXBSW47djL50uRcuKl1kYQ65piE40Pa dFjSngs1tFy4U3bZoiNKwhqxIC7al4aRMKD4F4XKeileMt1+37CkCYy+X1NeK0qu njp/DjzlmqLwK1dexXtf8AZVchFlYtlkxoH4zmkMBA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrgedttddgieelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepkfguohcu ufgthhhimhhmvghluceoihguohhstghhsehiughoshgthhdrohhrgheqnecuggftrfgrth htvghrnhephefhtdejvdeiffefudduvdffgeetieeigeeugfduffdvffdtfeehieejtdfh jeeknecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehiughoshgthhesihguohhstghhrdhorhhg X-ME-Proxy: Feedback-ID: i494840e7:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 22 Oct 2022 09:53:29 -0400 (EDT) Date: Sat, 22 Oct 2022 16:53:25 +0300 From: Ido Schimmel To: Michael Chan Cc: davem@davemloft.net, netdev@vger.kernel.org, kuba@kernel.org, edumazet@google.com, pabeni@redhat.com, gospo@broadcom.com, vikas.gupta@broadcom.com Subject: Re: [PATCH net-next v3 2/3] bnxt_en: add .get_module_eeprom_by_page() support Message-ID: References: <1666334243-23866-1-git-send-email-michael.chan@broadcom.com> <1666334243-23866-3-git-send-email-michael.chan@broadcom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1666334243-23866-3-git-send-email-michael.chan@broadcom.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, Oct 21, 2022 at 02:37:22AM -0400, Michael Chan wrote: > From: Vikas Gupta > > Add support for .get_module_eeprom_by_page() callback which > implements generic solution for module`s eeprom access. > > v3: Add bnxt_get_module_status() to get a more specific extack error > string. > Return -EINVAL from bnxt_get_module_eeprom_by_page() when we > don't want to fallback to old method. > v2: Simplification suggested by Ido Schimmel > > Link: https://lore.kernel.org/netdev/YzVJ%2FvKJugoz15yV@shredder/ > Cc: Ido Schimmel > Signed-off-by: Vikas Gupta > Signed-off-by: Michael Chan Reviewed-by: Ido Schimmel