From: Leon Romanovsky <leon@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, Slawomir Laba <slawomirx.laba@intel.com>,
Michal Jaron <michalx.jaron@intel.com>,
Mateusz Palczewski <mateusz.palczewski@intel.com>,
Gurucharan <gurucharanx.g@intel.com>
Subject: Re: [PATCH net] i40e: Fix ethtool rx-flow-hash setting for X722
Date: Sun, 23 Oct 2022 19:38:33 +0300 [thread overview]
Message-ID: <Y1VuCYixOEqWgBdc@unreal> (raw)
In-Reply-To: <20221021213819.3958289-1-jacob.e.keller@intel.com>
On Fri, Oct 21, 2022 at 02:38:19PM -0700, Jacob Keller wrote:
> From: Slawomir Laba <slawomirx.laba@intel.com>
>
> When enabling flow type for RSS hash via ethtool:
>
> ethtool -N $pf rx-flow-hash tcp4|tcp6|udp4|udp6 s|d
>
> the driver would fail to setup this setting on X722
> device since it was using the mask on the register
> dedicated for X710 devices.
>
> Apply a different mask on the register when setting the
> RSS hash for the X722 device.
>
> When displaying the flow types enabled via ethtool:
>
> ethtool -n $pf rx-flow-hash tcp4|tcp6|udp4|udp6
>
> the driver would print wrong values for X722 device.
>
> Fix this issue by testing masks for X722 device in
> i40e_get_rss_hash_opts function.
>
> Fixes: eb0dd6e4a3b3 ("i40e: Allow RSS Hash set with less than four parameters")
> Signed-off-by: Slawomir Laba <slawomirx.laba@intel.com>
> Signed-off-by: Michal Jaron <michalx.jaron@intel.com>
> Signed-off-by: Mateusz Palczewski <mateusz.palczewski@intel.com>
> Tested-by: Gurucharan <gurucharanx.g@intel.com> (A Contingent worker at Intel)
> ---
Jacob,
I don't see your SOB here.
Thanks
next prev parent reply other threads:[~2022-10-23 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-21 21:38 [PATCH net] i40e: Fix ethtool rx-flow-hash setting for X722 Jacob Keller
2022-10-23 16:38 ` Leon Romanovsky [this message]
2022-10-24 9:56 ` Keller, Jacob E
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1VuCYixOEqWgBdc@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=gurucharanx.g@intel.com \
--cc=jacob.e.keller@intel.com \
--cc=kuba@kernel.org \
--cc=mateusz.palczewski@intel.com \
--cc=michalx.jaron@intel.com \
--cc=netdev@vger.kernel.org \
--cc=slawomirx.laba@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox