From: Sabrina Dubroca <sd@queasysnail.net>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Eric Dumazet <edumazet@google.com>,
syzbot <syzbot+1e9af9185d8850e2c2fa@syzkaller.appspotmail.com>,
davem@davemloft.net, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
pabeni@redhat.com, steffen.klassert@secunet.com,
syzkaller-bugs@googlegroups.com
Subject: Re: [v2 PATCH] af_key: Fix send_acquire race with pfkey_register
Date: Mon, 24 Oct 2022 09:20:00 +0200 [thread overview]
Message-ID: <Y1Y8oN5xcIoMu+SH@hog> (raw)
In-Reply-To: <Y1YrVGP+5TP7V1/R@gondor.apana.org.au>
2022-10-24, 14:06:12 +0800, Herbert Xu wrote:
> @@ -1697,11 +1699,11 @@ static int pfkey_register(struct sock *sk, struct sk_buff *skb, const struct sad
> pfk->registered |= (1<<hdr->sadb_msg_satype);
> }
>
> - mutex_lock(&pfkey_mutex);
> + spin_lock_bh(&pfkey_alg_lock);
> xfrm_probe_algs();
I don't think we can do that:
void xfrm_probe_algs(void)
{
int i, status;
BUG_ON(in_softirq());
>
> supp_skb = compose_sadb_supported(hdr, GFP_KERNEL | __GFP_ZERO);
> - mutex_unlock(&pfkey_mutex);
> + spin_unlock_bh(&pfkey_alg_lock);
>
> if (!supp_skb) {
> if (hdr->sadb_msg_satype != SADB_SATYPE_UNSPEC)
--
Sabrina
next prev parent reply other threads:[~2022-10-24 7:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-24 2:37 [syzbot] kernel BUG in warn_crc32c_csum_combine syzbot
2022-10-24 2:49 ` Eric Dumazet
2022-10-24 5:01 ` Herbert Xu
2022-10-24 5:10 ` [PATCH] af_key: Fix send_acquire race with pfkey_register Herbert Xu
2022-10-24 5:21 ` Eric Dumazet
2022-10-24 6:06 ` [v2 PATCH] " Herbert Xu
2022-10-24 6:31 ` Eric Dumazet
2022-10-25 5:46 ` Herbert Xu
2022-10-24 7:20 ` Sabrina Dubroca [this message]
2022-10-25 6:06 ` [v3 " Herbert Xu
2022-10-26 13:38 ` Sabrina Dubroca
2022-10-27 3:42 ` Herbert Xu
2022-10-27 3:45 ` Eric Dumazet
2022-10-27 3:55 ` Herbert Xu
2022-10-28 11:26 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1Y8oN5xcIoMu+SH@hog \
--to=sd@queasysnail.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=steffen.klassert@secunet.com \
--cc=syzbot+1e9af9185d8850e2c2fa@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).