From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 584B1C04A95 for ; Tue, 25 Oct 2022 07:48:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231883AbiJYHr7 (ORCPT ); Tue, 25 Oct 2022 03:47:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51396 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232016AbiJYHrx (ORCPT ); Tue, 25 Oct 2022 03:47:53 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A757164BF0 for ; Tue, 25 Oct 2022 00:47:47 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id AAE9B617BF for ; Tue, 25 Oct 2022 07:47:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C894C433D6; Tue, 25 Oct 2022 07:47:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1666684066; bh=JNAWT4oFb5wQuBeGH9wRfX94aXqbjPZKVfUUpGCZeic=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eBZ1X2r2W5FY0blizUjBfmHmeGjo5Iu90lXVy03ay6XjzkI5koeZERcOEbSHFp8Bf sUkEjZt6QVILJei3QJ3rOmTVS9IYV1laLfG9e8SqxAJGb8RM7XfeedVs5KS4hnnmLh LvQaBvDSo2K7Dqrn6mvQxWjVknRllLuYupCtCLKWP1k8mElY/yDYgFQ/jCwWK7ZOqy EXip/37A8DFoQX3vesVy5Y4X7piMwRNsN25wuCfmAIOFX+D9BvI3soZ4eCUPxIp2aN F0qBt5DG/HtiJj/0OdBZeht9K0nHTpbhf5tVT1E+nu3goxEhsaVxeaGvYFS0tQtHSE vrMCZUAhrNDDA== Date: Tue, 25 Oct 2022 10:47:42 +0300 From: Leon Romanovsky To: Yang Yingliang Cc: netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org Subject: Re: [PATCH net] net: fealnx: fix missing pci_disable_device() Message-ID: References: <20221024135728.2894863-1-yangyingliang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221024135728.2894863-1-yangyingliang@huawei.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Oct 24, 2022 at 09:57:28PM +0800, Yang Yingliang wrote: > pci_disable_device() need be called while module exiting, switch > to use pcim_enable(), pci_disable_device() and pci_release_regions() > will be called in pcim_release() while unbinding device. I didn't understand the description at all, maybe people in CC will. Most likely, you wanted something like this: diff --git a/drivers/net/ethernet/fealnx.c b/drivers/net/ethernet/fealnx.c index ed18450fd2cc..78107dd4aa57 100644 --- a/drivers/net/ethernet/fealnx.c +++ b/drivers/net/ethernet/fealnx.c @@ -690,6 +690,7 @@ static void fealnx_remove_one(struct pci_dev *pdev) pci_iounmap(pdev, np->mem); free_netdev(dev); pci_release_regions(pdev); + pci_disable_device(pdev); } else printk(KERN_ERR "fealnx: remove for unknown device\n"); > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Signed-off-by: Yang Yingliang > --- > drivers/net/ethernet/fealnx.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/fealnx.c b/drivers/net/ethernet/fealnx.c > index ed18450fd2cc..fb139f295b67 100644 > --- a/drivers/net/ethernet/fealnx.c > +++ b/drivers/net/ethernet/fealnx.c > @@ -494,7 +494,7 @@ static int fealnx_init_one(struct pci_dev *pdev, > > option = card_idx < MAX_UNITS ? options[card_idx] : 0; > > - i = pci_enable_device(pdev); > + i = pcim_enable_device(pdev); > if (i) return i; > pci_set_master(pdev); > > @@ -670,7 +670,6 @@ static int fealnx_init_one(struct pci_dev *pdev, > err_out_unmap: > pci_iounmap(pdev, ioaddr); > err_out_res: > - pci_release_regions(pdev); > return err; > } > > @@ -689,7 +688,6 @@ static void fealnx_remove_one(struct pci_dev *pdev) > unregister_netdev(dev); > pci_iounmap(pdev, np->mem); > free_netdev(dev); > - pci_release_regions(pdev); > } else > printk(KERN_ERR "fealnx: remove for unknown device\n"); > } > -- > 2.25.1 >