From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DD33FA373E for ; Tue, 25 Oct 2022 08:21:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231868AbiJYIVl (ORCPT ); Tue, 25 Oct 2022 04:21:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232200AbiJYIVe (ORCPT ); Tue, 25 Oct 2022 04:21:34 -0400 Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [IPv6:2001:4d48:ad52:32c8:5054:ff:fe00:142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C54DFF248; Tue, 25 Oct 2022 01:21:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=EtmojnUqnCVKWOh8C7J92DZrsq9/z0GK3KV0rT9mLpw=; b=BiKMTB/c8/919DvH6LZjZyf2T7 Lk+Oc0WQgSHrU043Y+cnUTrcCAWFFIRwbP/gwShZJOH7Ph6ZjNkE4YzQLwl+rZ6FQMYOZVZ1KaAAv JrHnpzzBk58E6Bw1q1q6MogLgb0j7g2H4c3zZg9FWX17eaRq/RM83PQCbfJMvNXNS9KzKq0aINVsM KaygbGcRwn6F39U9DxcVpgeF99Nlne7F879RubTg63DmK7uq37EnDvG5KYZFfCKozoHb2sgk7eO4l lwO6xacAFy+7uJjlKmYCqjbyjVIn9IsBwGV8SHQv4hpDF3zC3DsR7nT9nOHu1R4lpXKIo3O5UJycU fdMcQzOw==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:34940) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1onFBQ-0004Dt-7i; Tue, 25 Oct 2022 09:21:12 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1onFBL-0007xV-IX; Tue, 25 Oct 2022 09:21:07 +0100 Date: Tue, 25 Oct 2022 09:21:07 +0100 From: "Russell King (Oracle)" To: Jakub Kicinski Cc: kernel test robot , Andrew Morton , ntfs3@lists.linux.dev, netdev@vger.kernel.org, linux-parisc@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, amd-gfx@lists.freedesktop.org, Linux Memory Management List Subject: Re: [linux-next:master] BUILD SUCCESS WITH WARNING 76cf65d1377f733af1e2a55233e3353ffa577f54 Message-ID: References: <6356c451.pwLIF+9EvDUrDjTY%lkp@intel.com> <20221024145527.0eff7844@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221024145527.0eff7844@kernel.org> Sender: Russell King (Oracle) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Oct 24, 2022 at 02:55:27PM -0700, Jakub Kicinski wrote: > On Tue, 25 Oct 2022 00:58:57 +0800 kernel test robot wrote: > > drivers/net/phy/phylink.c:588 phylink_validate_mask_caps() warn: variable dereferenced before check 'state' (see line 583) > > Hi Russell, I think the warning is semi-legit. Your commit f392a1846489 > ("net: phylink: provide phylink_validate_mask_caps() helper") added an > if (state) before defer'ing state but it's already deref'ed higher up > so can't be null. Not me, Sean. My original implementation of phylink_validate_mask_caps() doesn't know anything about rate matching, so my version didn't have this issue. Sean's version of my patch (which is what was submitted) added the dereference that causes this, so, it's up to Sean to figure out a fix - but he reading his follow up to the build bot's message, he seems to be passing it over to me to fix! I've got other issues to be worked on right now, and have no time to spare to fix other people's mistakes. Sorry. You can't always rely on the apparent author mentioned in the commit to be the actual person responsible for the changes in a patch. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!