From: Leon Romanovsky <leon@kernel.org>
To: Rohit Nair <rohit.sajan.kumar@oracle.com>
Cc: jgg@ziepe.ca, saeedm@nvidia.com, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, manjunath.b.patil@oracle.com,
rama.nichanamatlu@oracle.com,
Michael Guralnik <michaelgur@nvidia.com>
Subject: Re: [External] : Re: [PATCH 1/1] IB/mlx5: Add a signature check to received EQEs and CQEs
Date: Thu, 27 Oct 2022 15:23:20 +0300 [thread overview]
Message-ID: <Y1p4OEIWNObQCDoG@unreal> (raw)
In-Reply-To: <5bab650a-3c0b-cfd2-d6a7-2e39c8474514@oracle.com>
On Tue, Oct 25, 2022 at 10:44:12AM -0700, Rohit Nair wrote:
> Hey Leon,
>
> Please find my replies to your comments here below:
<...>
> >
> > > This patch does not introduce any significant performance degradations
> > > and has been tested using qperf.
> > What does it mean? You made changes in kernel verbs flow, they are not
> > executed through qperf.
> We also conducted several extensive performance tests using our test-suite
> which utilizes rds-stress and also saw no significant performance
> degrdations in those results.
What does it mean "also"? Your change is applicable ONLY for kernel path.
Anyway, I'm not keen adding rare debug code to performance critical path.
Thanks
next prev parent reply other threads:[~2022-10-27 12:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-05 17:45 [PATCH 1/1] IB/mlx5: Add a signature check to received EQEs and CQEs Rohit Nair
2022-10-11 7:17 ` Leon Romanovsky
2022-10-25 17:44 ` [External] : " Rohit Nair
2022-10-27 12:23 ` Leon Romanovsky [this message]
2022-10-28 23:48 ` Rohit Nair
2022-11-06 18:03 ` Leon Romanovsky
2022-11-07 17:51 ` Rohit Nair
[not found] ` <f3a56720-4df4-6b17-bfdf-4385dc27a2c0@oracle.com>
2022-11-09 18:33 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1p4OEIWNObQCDoG@unreal \
--to=leon@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jgg@ziepe.ca \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=manjunath.b.patil@oracle.com \
--cc=michaelgur@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rama.nichanamatlu@oracle.com \
--cc=rohit.sajan.kumar@oracle.com \
--cc=saeedm@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).