From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Heiner Kallweit <hkallweit1@gmail.com>,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] net: sfp: convert register indexes from hex to decimal
Date: Thu, 27 Oct 2022 15:46:24 +0100 [thread overview]
Message-ID: <Y1qZwF4OB96WK1ye@shell.armlinux.org.uk> (raw)
In-Reply-To: <Y1qY+nwr4SzmyhhD@lunn.ch>
On Thu, Oct 27, 2022 at 04:43:06PM +0200, Andrew Lunn wrote:
> On Thu, Oct 27, 2022 at 02:21:16PM +0100, Russell King (Oracle) wrote:
> > The register indexes in the standards are in decimal rather than hex,
> > so lets specify them in decimal in the header file so we can easily
> > cross-reference without converting between hex and decimal.
> >
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
>
> Makes sense, but i've not checked for typos. Did you see if the
> generated code remains identical?
I did and it does remain identical.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2022-10-27 14:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 13:21 [PATCH net-next 0/2] Clean up SFP register definitions Russell King (Oracle)
2022-10-27 13:21 ` [PATCH net-next 1/2] net: sfp: convert register indexes from hex to decimal Russell King (Oracle)
2022-10-27 14:43 ` Andrew Lunn
2022-10-27 14:46 ` Russell King (Oracle) [this message]
2022-10-27 13:21 ` [PATCH net-next 2/2] net: sfp: move field definitions along side register index Russell King (Oracle)
2022-10-27 14:43 ` Andrew Lunn
2022-10-29 5:10 ` [PATCH net-next 0/2] Clean up SFP register definitions patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1qZwF4OB96WK1ye@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).