From: Andrew Lunn <andrew@lunn.ch>
To: David Thompson <davthompson@nvidia.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org, cai.huoqing@linux.dev,
brgl@bgdev.pl, limings@nvidia.com,
Asmaa Mnebhi <asmaa@nvidia.com>
Subject: Re: [PATCH net-next v1 4/4] mlxbf_gige: add BlueField-3 ethtool_ops
Date: Fri, 28 Oct 2022 01:29:09 +0200 [thread overview]
Message-ID: <Y1sURRYUzwDCbpjX@lunn.ch> (raw)
In-Reply-To: <20221027220013.24276-5-davthompson@nvidia.com>
On Thu, Oct 27, 2022 at 06:00:13PM -0400, David Thompson wrote:
> This patch adds logic to support initialization of a
> BlueField-3 specific "ethtool_ops" data structure. The
> BlueField-3 data structure supports the "set_link_ksettings"
> callback, while the BlueField-2 data structure does not.
Why?
I _think_, so long as the supported values have been set correctly in
the phydev, set_link_ksettings should not be able to set anything for
BF2 which it cannot support.
Andrew
prev parent reply other threads:[~2022-10-27 23:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-27 22:00 [PATCH net-next v1 0/4] mlxbf_gige: add BlueField-3 support David Thompson
2022-10-27 22:00 ` [PATCH net-next v1 1/4] mlxbf_gige: add MDIO support for BlueField-3 David Thompson
2022-10-27 22:00 ` [PATCH net-next v1 2/4] mlxbf_gige: support 10M/100M/1G speeds on BlueField-3 David Thompson
2022-10-27 23:14 ` Andrew Lunn
2022-10-27 22:00 ` [PATCH net-next v1 3/4] mlxbf_gige: add BlueField-3 Serdes configuration David Thompson
2022-10-27 23:25 ` Andrew Lunn
2022-10-28 15:08 ` Asmaa Mnebhi
2022-10-27 22:00 ` [PATCH net-next v1 4/4] mlxbf_gige: add BlueField-3 ethtool_ops David Thompson
2022-10-27 23:29 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1sURRYUzwDCbpjX@lunn.ch \
--to=andrew@lunn.ch \
--cc=asmaa@nvidia.com \
--cc=brgl@bgdev.pl \
--cc=cai.huoqing@linux.dev \
--cc=davem@davemloft.net \
--cc=davthompson@nvidia.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=limings@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).