From: Dan Carpenter <dan.carpenter@oracle.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: наб <nabijaczleweli@nabijaczleweli.xyz>,
"Jonathan Corbet" <corbet@lwn.net>,
"Federico Vaga" <federico.vaga@vaga.pv.it>,
"Alex Shi" <alexs@kernel.org>,
"Yanteng Si" <siyanteng@loongson.cn>,
"Hu Haowen" <src.res@email.cn>,
"Thomas Sailer" <t.sailer@alumni.ethz.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kiciński" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc-tw-discuss@lists.sourceforge.net,
linux-hams@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 01/15] hamradio: baycom: remove BAYCOM_MAGIC
Date: Fri, 28 Oct 2022 16:43:14 +0300 [thread overview]
Message-ID: <Y1vccrsHSnF1QOIb@kadam> (raw)
In-Reply-To: <47c2bffb-6bfe-7f5d-0d2d-3cbb99d31019@gmail.com>
On Fri, Oct 28, 2022 at 08:13:49PM +0700, Bagas Sanjaya wrote:
> On 10/27/22 05:42, наб wrote:
> > Since defanging in v2.6.12-rc1 it's set exactly once per port on probe
> > and checked exactly once per port on unload: it's useless. Kill it.
> >
>
> What do you mean by defanging in that release?
I was also curious about this, but I accidentally sent my question
privately instead of to the list.
>
> Also, s/Kill it/Remove BAYCOM_MAGIC from magic numbers table/ (your
> wording is kinda mature).
>
The kernel has almost 13 thousand kills...
$ git grep -i kill | wc -l
12975
$
It's fine.
regards,
dan carpenter
next prev parent reply other threads:[~2022-10-28 13:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 22:42 [PATCH 01/15] hamradio: baycom: remove BAYCOM_MAGIC наб
2022-10-26 22:42 ` [PATCH 02/15] hamradio: yam: remove YAM_MAGIC наб
2022-10-28 13:19 ` Bagas Sanjaya
2022-10-28 13:44 ` Dan Carpenter
2022-10-26 22:43 ` [PATCH 11/15] hdlcdrv: remove HDLCDRV_MAGIC наб
2022-10-28 13:54 ` Bagas Sanjaya
2022-10-26 22:43 ` [PATCH 12/15] drivers: net: slip: remove SLIP_MAGIC наб
2022-10-27 13:11 ` Oliver Hartkopp
2022-10-27 13:45 ` наб
2022-10-28 13:57 ` Bagas Sanjaya
2022-10-27 1:37 ` [PATCH 01/15] hamradio: baycom: remove BAYCOM_MAGIC Jakub Kicinski
2022-10-28 1:54 ` Bagas Sanjaya
2022-10-28 13:13 ` Bagas Sanjaya
2022-10-28 13:43 ` Dan Carpenter [this message]
2022-10-28 13:50 ` Bagas Sanjaya
2022-10-28 14:07 ` Dan Carpenter
2022-10-28 21:43 ` наб
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1vccrsHSnF1QOIb@kadam \
--to=dan.carpenter@oracle.com \
--cc=alexs@kernel.org \
--cc=bagasdotme@gmail.com \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=federico.vaga@vaga.pv.it \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc-tw-discuss@lists.sourceforge.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hams@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nabijaczleweli@nabijaczleweli.xyz \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=siyanteng@loongson.cn \
--cc=src.res@email.cn \
--cc=t.sailer@alumni.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).